Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: src/code-stubs.cc

Issue 2568713002: [stubs] Fixing issues found by machine graph verifier in code stubs. (Closed)
Patch Set: Addressing nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/accessor-assembler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/code-stubs.h" 5 #include "src/code-stubs.h"
6 6
7 #include <sstream> 7 #include <sstream>
8 8
9 #include "src/ast/ast.h" 9 #include "src/ast/ast.h"
10 #include "src/bootstrapper.h" 10 #include "src/bootstrapper.h"
(...skipping 419 matching lines...) Expand 10 before | Expand all | Expand 10 after
430 } 430 }
431 } 431 }
432 432
433 Handle<Code> TurboFanCodeStub::GenerateCode() { 433 Handle<Code> TurboFanCodeStub::GenerateCode() {
434 const char* name = CodeStub::MajorName(MajorKey()); 434 const char* name = CodeStub::MajorName(MajorKey());
435 Zone zone(isolate()->allocator(), ZONE_NAME); 435 Zone zone(isolate()->allocator(), ZONE_NAME);
436 CallInterfaceDescriptor descriptor(GetCallInterfaceDescriptor()); 436 CallInterfaceDescriptor descriptor(GetCallInterfaceDescriptor());
437 compiler::CodeAssemblerState state(isolate(), &zone, descriptor, 437 compiler::CodeAssemblerState state(isolate(), &zone, descriptor,
438 GetCodeFlags(), name); 438 GetCodeFlags(), name);
439 GenerateAssembly(&state); 439 GenerateAssembly(&state);
440 return compiler::CodeAssembler::GenerateCode(&state); 440
441 // TODO(ishell): remove this when code stub assembler graphs verification
442 // is enabled for all stubs.
443 bool saved_csa_verify = FLAG_csa_verify;
444 // Enable verification only in mksnapshot.
445 FLAG_csa_verify = DEBUG_BOOL && FLAG_startup_blob != nullptr;
446 Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state);
447 FLAG_csa_verify = saved_csa_verify;
448 return code;
441 } 449 }
442 450
443 #define ACCESSOR_ASSEMBLER(Name) \ 451 #define ACCESSOR_ASSEMBLER(Name) \
444 void Name##Stub::GenerateAssembly(CodeAssemblerState* state) const { \ 452 void Name##Stub::GenerateAssembly(CodeAssemblerState* state) const { \
445 AccessorAssembler::Generate##Name(state); \ 453 AccessorAssembler::Generate##Name(state); \
446 } 454 }
447 455
448 ACCESSOR_ASSEMBLER(LoadIC) 456 ACCESSOR_ASSEMBLER(LoadIC)
449 ACCESSOR_ASSEMBLER(LoadICTrampoline) 457 ACCESSOR_ASSEMBLER(LoadICTrampoline)
450 ACCESSOR_ASSEMBLER(KeyedLoadICTF) 458 ACCESSOR_ASSEMBLER(KeyedLoadICTF)
(...skipping 2766 matching lines...) Expand 10 before | Expand all | Expand 10 after
3217 } 3225 }
3218 3226
3219 ArrayConstructorStub::ArrayConstructorStub(Isolate* isolate) 3227 ArrayConstructorStub::ArrayConstructorStub(Isolate* isolate)
3220 : PlatformCodeStub(isolate) {} 3228 : PlatformCodeStub(isolate) {}
3221 3229
3222 InternalArrayConstructorStub::InternalArrayConstructorStub(Isolate* isolate) 3230 InternalArrayConstructorStub::InternalArrayConstructorStub(Isolate* isolate)
3223 : PlatformCodeStub(isolate) {} 3231 : PlatformCodeStub(isolate) {}
3224 3232
3225 } // namespace internal 3233 } // namespace internal
3226 } // namespace v8 3234 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/accessor-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698