Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Unified Diff: src/code-stubs.cc

Issue 2568713002: [stubs] Fixing issues found by machine graph verifier in code stubs. (Closed)
Patch Set: Addressing nits Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/accessor-assembler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.cc
diff --git a/src/code-stubs.cc b/src/code-stubs.cc
index c97ba3db2d59ed3458505b1f359f3e8432db8a34..405f617c53fe5d41bec4506a615078e12e931b75 100644
--- a/src/code-stubs.cc
+++ b/src/code-stubs.cc
@@ -437,7 +437,15 @@ Handle<Code> TurboFanCodeStub::GenerateCode() {
compiler::CodeAssemblerState state(isolate(), &zone, descriptor,
GetCodeFlags(), name);
GenerateAssembly(&state);
- return compiler::CodeAssembler::GenerateCode(&state);
+
+ // TODO(ishell): remove this when code stub assembler graphs verification
+ // is enabled for all stubs.
+ bool saved_csa_verify = FLAG_csa_verify;
+ // Enable verification only in mksnapshot.
+ FLAG_csa_verify = DEBUG_BOOL && FLAG_startup_blob != nullptr;
+ Handle<Code> code = compiler::CodeAssembler::GenerateCode(&state);
+ FLAG_csa_verify = saved_csa_verify;
+ return code;
}
#define ACCESSOR_ASSEMBLER(Name) \
« no previous file with comments | « src/code-stub-assembler.cc ('k') | src/ic/accessor-assembler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698