Separate state updating code from MemoryCoordinatorImpl

Separate state updating code from MemoryCoordinatorImpl

We are going to merge MemoryCoordinator into MemoryCoordinatorImpl
as a part of preparations for adding an pure interface of
MemoryCoordinator in base/. Since they are not simple classes,
just merging them will create a big class which has multiple
responsibilities. Before merging them, factor out state updating
code from MemoryCoordinatorImpl.

BUG=673216
Committed: https://crrev.com/c6e173428db849e69d2d03a9a208230b77f54ee8
Cr-Commit-Position: refs/heads/master@{#438743}

[bashi, 2016-12-13 03:22:16]

bashi@chromium.org changed reviewers:
+ chrisha@chromium.org, haraken@chromium.org

[bashi, 2016-12-13 03:22:16]

Context: https://codereview.chromium.org/2565323002/#msg28

I want to merge MemoryCoordinator and MemoryCoordinatorImpl so that we can have
MemoryCoordinator interface in base/. Simply merging them will create one big
class so it would be better to separate state updating code from Impl. What do
you think about this? In the end we will have followings:
- content::MemoryCoordinatorImpl (dispatching, state management)
- content::MemoryStateUpdater (schedule state update)
- base::MemoryCoordinator (pure interface)
- base::MemoryCoordinatorProxy (proxy class for MemoryCoordinator)

[haraken, 2016-12-13 03:59:16]

LGTM

[bashi, 2016-12-13 06:36:10]

Description was changed from

==========
WIP: Separate state updating code from MemoryCoordinatorImpl

descripton to be written.

BUG=673216
==========

to

==========
Separate state updating code from MemoryCoordinatorImpl

We are going to merge MemoryCoordinator into MemoryCoordinatorImpl
as a part of preparations for adding an pure interface of
MemoryCoordinator in base/. Since they are not simple classes,
just merging them will create a big class which has multiple
responsibilities. Before merging them, factor out state updating
code from MemoryCoordinatorImpl.

BUG=673216
==========

[bashi, 2016-12-13 06:36:42]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 06:36:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[bashi, 2016-12-13 06:39:33]

Thanks. I tried to split unittests as well but failed as it's a bit difficult to
do without adding another abstraction layer. Just updated the description and
class comments.

[bashi, 2016-12-13 06:40:04]

bashi@chromium.org changed reviewers:
+ boliu@chromium.org

[bashi, 2016-12-13 06:40:05]

+boliu@ for content/browser/BUILD.gn

[commit-bot: I haz the power, 2016-12-13 07:27:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 07:27:47]

Dry run: This issue passed the CQ dry run.

[boliu, 2016-12-13 16:06:58]

On 2016/12/13 06:40:05, bashi1 wrote:
> +boliu@ for content/browser/BUILD.gn

rs lgtm

[bashi, 2016-12-15 00:37:38]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-12-15 00:37:39]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2568393002/#ps20001
(title: "comments and tweaks")

[commit-bot: I haz the power, 2016-12-15 00:38:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 00:46:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 00:46:22]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[bashi, 2016-12-15 02:02:56]

The CQ bit was checked by bashi@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:03:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 02:10:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:10:17]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[bashi, 2016-12-15 02:24:24]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 02:24:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 02:32:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 02:32:38]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[bashi, 2016-12-15 02:43:51]

The CQ bit was checked by bashi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 02:44:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:30:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 04:30:44]

Dry run: This issue passed the CQ dry run.

[bashi, 2016-12-15 04:32:10]

The CQ bit was checked by bashi@chromium.org

[bashi, 2016-12-15 04:32:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, boliu@chromium.org
Link to the patchset: https://codereview.chromium.org/2568393002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-15 04:32:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 04:37:47]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1481776330452120,
"parent_rev": "e8a36a360b7fa89a6cdc95576e6a27b1791029da", "commit_rev":
"a86c7423bfc9fd13a66b61250810f3bd7025fae9"}

[commit-bot: I haz the power, 2016-12-15 04:38:15]

Description was changed from

==========
Separate state updating code from MemoryCoordinatorImpl

We are going to merge MemoryCoordinator into MemoryCoordinatorImpl
as a part of preparations for adding an pure interface of
MemoryCoordinator in base/. Since they are not simple classes,
just merging them will create a big class which has multiple
responsibilities. Before merging them, factor out state updating
code from MemoryCoordinatorImpl.

BUG=673216
==========

to

==========
Separate state updating code from MemoryCoordinatorImpl

We are going to merge MemoryCoordinator into MemoryCoordinatorImpl
as a part of preparations for adding an pure interface of
MemoryCoordinator in base/. Since they are not simple classes,
just merging them will create a big class which has multiple
responsibilities. Before merging them, factor out state updating
code from MemoryCoordinatorImpl.

BUG=673216

Review-Url: https://codereview.chromium.org/2568393002
==========

[commit-bot: I haz the power, 2016-12-15 04:38:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-12-15 04:41:25]

Description was changed from

==========
Separate state updating code from MemoryCoordinatorImpl

We are going to merge MemoryCoordinator into MemoryCoordinatorImpl
as a part of preparations for adding an pure interface of
MemoryCoordinator in base/. Since they are not simple classes,
just merging them will create a big class which has multiple
responsibilities. Before merging them, factor out state updating
code from MemoryCoordinatorImpl.

BUG=673216

Review-Url: https://codereview.chromium.org/2568393002
==========

to

==========
Separate state updating code from MemoryCoordinatorImpl

We are going to merge MemoryCoordinator into MemoryCoordinatorImpl
as a part of preparations for adding an pure interface of
MemoryCoordinator in base/. Since they are not simple classes,
just merging them will create a big class which has multiple
responsibilities. Before merging them, factor out state updating
code from MemoryCoordinatorImpl.

BUG=673216

Committed: https://crrev.com/c6e173428db849e69d2d03a9a208230b77f54ee8
Cr-Commit-Position: refs/heads/master@{#438743}
==========

[commit-bot: I haz the power, 2016-12-15 04:41:27]

Patchset 3 (id:??) landed as
https://crrev.com/c6e173428db849e69d2d03a9a208230b77f54ee8
Cr-Commit-Position: refs/heads/master@{#438743}