Clean up Document::isSecureContext

Clean up Document::isSecureContext

Document has two methods for getting whether the context is secure.
These duplicate functionality, but one also allocates an error string
for insecure contexts.

Many callers do not need the error string, so this patch updates them
to use the other isSecureContext method. The patch also consolidates
duplicate logic.

The error string allocation was seen in profiles in
RenderFrameImpl::willSendRequest

BUG=348655
Committed: https://crrev.com/378f5a723e7ee9c00a5af9470880a324c12f556b
Cr-Commit-Position: refs/heads/master@{#437998}

[Charlie Harrison, 2016-12-12 21:57:40]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 21:59:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2016-12-12 22:39:09]

csharrison@chromium.org changed reviewers:
+ creis@chromium.org, haraken@chromium.org

[Charlie Harrison, 2016-12-12 22:39:10]

haraken: PTAL at all of Blink? Let me know if you'd like me to pick more
specific owners.

creis: PTAL at //content

[Charlie Reis, 2016-12-12 23:06:42]

content/ LGTM

[commit-bot: I haz the power, 2016-12-13 00:59:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 00:59:08]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-12-13 01:06:46]

LGTM

[Charlie Harrison, 2016-12-13 02:38:12]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2016-12-13 02:39:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 02:46:35]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481596692834050, "parent_rev":
"581bc832baee1b3be2add781889964cdb16969b2", "commit_rev":
"d7a87aa340b0c849d22b07121be11901d911357c"}

[commit-bot: I haz the power, 2016-12-13 02:47:05]

Description was changed from

==========
Clean up Document::isSecureContext

Document has two methods for getting whether the context is secure.
These duplicate functionality, but one also allocates an error string
for insecure contexts.

Many callers do not need the error string, so this patch updates them
to use the other isSecureContext method. The patch also consolidates
duplicate logic.

The error string allocation was seen in profiles in
RenderFrameImpl::willSendRequest

BUG=348655
==========

to

==========
Clean up Document::isSecureContext

Document has two methods for getting whether the context is secure.
These duplicate functionality, but one also allocates an error string
for insecure contexts.

Many callers do not need the error string, so this patch updates them
to use the other isSecureContext method. The patch also consolidates
duplicate logic.

The error string allocation was seen in profiles in
RenderFrameImpl::willSendRequest

BUG=348655

Review-Url: https://codereview.chromium.org/2567173002
==========

[commit-bot: I haz the power, 2016-12-13 02:47:07]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-13 02:48:46]

Description was changed from

==========
Clean up Document::isSecureContext

Document has two methods for getting whether the context is secure.
These duplicate functionality, but one also allocates an error string
for insecure contexts.

Many callers do not need the error string, so this patch updates them
to use the other isSecureContext method. The patch also consolidates
duplicate logic.

The error string allocation was seen in profiles in
RenderFrameImpl::willSendRequest

BUG=348655

Review-Url: https://codereview.chromium.org/2567173002
==========

to

==========
Clean up Document::isSecureContext

Document has two methods for getting whether the context is secure.
These duplicate functionality, but one also allocates an error string
for insecure contexts.

Many callers do not need the error string, so this patch updates them
to use the other isSecureContext method. The patch also consolidates
duplicate logic.

The error string allocation was seen in profiles in
RenderFrameImpl::willSendRequest

BUG=348655

Committed: https://crrev.com/378f5a723e7ee9c00a5af9470880a324c12f556b
Cr-Commit-Position: refs/heads/master@{#437998}
==========

[commit-bot: I haz the power, 2016-12-13 02:48:47]

Patchset 1 (id:??) landed as
https://crrev.com/378f5a723e7ee9c00a5af9470880a324c12f556b
Cr-Commit-Position: refs/heads/master@{#437998}