third_party/WebKit/Source/modules/vr/VRDisplay.cpp - Issue 2567173002: Clean up Document::isSecureContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

Issue 2567173002: Clean up Document::isSecureContext (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/vr/VRDisplay.cpp

diff --git a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

index debe0fbb00e63bdbc73428496e02b74aa827bdb2..f4ed320cc08a64a6e4e702780e0f580cb96d374d 100644

--- a/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

+++ b/third_party/WebKit/Source/modules/vr/VRDisplay.cpp

@@ -283,8 +283,7 @@ ScriptPromise VRDisplay::requestPresent(ScriptState* scriptState,

const HeapVector<VRLayer>& layers) {

ExecutionContext* executionContext = scriptState->getExecutionContext();

UseCounter::count(executionContext, UseCounter::VRRequestPresent);

- String errorMessage;

- if (!executionContext->isSecureContext(errorMessage)) {

+ if (!executionContext->isSecureContext()) {

UseCounter::count(executionContext,

UseCounter::VRRequestPresentInsecureOrigin);

}