third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp - Issue 2567173002: Clean up Document::isSecureContext

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

Issue 2567173002: Clean up Document::isSecureContext (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp b/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

index 13f4441309148e24802422d422b38e656d472616..7ed68f530016171a98d838cfbb29ce7532612bb0 100644

--- a/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

+++ b/third_party/WebKit/Source/web/SharedWorkerRepositoryClientImpl.cpp

@@ -144,9 +144,7 @@ void SharedWorkerRepositoryClientImpl::connect(

}

WebWorkerCreationError creationError;

- String unusedSecureContextError;

- bool isSecureContext =

- worker->getExecutionContext()->isSecureContext(unusedSecureContextError);

+ bool isSecureContext = worker->getExecutionContext()->isSecureContext();

std::unique_ptr<WebSharedWorkerConnector> webWorkerConnector =

WTF::wrapUnique(m_client->createSharedWorkerConnector(

url, name, getId(document), header, headerType,