Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(573)

Issue 2566823002: Remove deprecated ExceptionState constructors. (Closed)

Created:
4 years ago by dcheng
Modified:
4 years ago
Reviewers:
haraken, Yuki
CC:
chromium-reviews, caseq+blink_chromium.org, blink-reviews-style_chromium.org, mlamouri+watch-blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove deprecated ExceptionState constructors. BUG=673090 Committed: https://crrev.com/8ca234a6e47d326f9b4513fe93b86ff7afd162e0 Cr-Commit-Position: refs/heads/master@{#437773}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -109 lines) Patch
M third_party/WebKit/Source/bindings/core/v8/ExceptionState.h View 1 chunk +0 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp View 2 chunks +4 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/ScriptCustomElementDefinition.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V0CustomElementConstructorBuilder.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8DOMWrapper.cpp View 3 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CSSStyleDeclarationCustom.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8CustomEventCustom.cpp View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8DevToolsHostCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8DocumentCustom.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MessageEventCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8MutationObserverCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp View 5 chunks +11 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h View 1 chunk +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/modules/v8/custom/V8DeviceMotionEventCustom.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/attributes.cpp.tmpl View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl View 1 chunk +1 line, -1 line 1 comment Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterface.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestInterfaceCheckSecurity.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp View 11 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/inspector/MainThreadDebugger.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/permissions/Permissions.cpp View 4 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
dcheng
https://codereview.chromium.org/2566823002/diff/1/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl File third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl (right): https://codereview.chromium.org/2566823002/diff/1/third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl#newcode504 third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl:504: ExceptionState exceptionState(info.GetIsolate(), ExceptionState::SetterContext, "{{interface_name}}", *attributeName); I thought about adding ...
4 years ago (2016-12-10 07:42:13 UTC) #5
haraken
LGTM
4 years ago (2016-12-10 12:56:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566823002/1
4 years ago (2016-12-10 18:14:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 18:19:13 UTC) #13
Yuki
LGTM. Thanks for doing this.
4 years ago (2016-12-12 03:45:04 UTC) #14
commit-bot: I haz the power
4 years ago (2016-12-12 15:07:10 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8ca234a6e47d326f9b4513fe93b86ff7afd162e0
Cr-Commit-Position: refs/heads/master@{#437773}

Powered by Google App Engine
This is Rietveld 408576698