third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp - Issue 2566823002: Remove deprecated ExceptionState constructors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

Issue 2566823002: Remove deprecated ExceptionState constructors. (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/custom/V8WindowCustom.cpp ('k') | third_party/WebKit/Source/bindings/modules/v8/V8ServiceWorkerMessageEventInternal.h » ('j') | third_party/WebKit/Source/bindings/templates/interface.cpp.tmpl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp b/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

index 6bb598c257cdb7b69bff3287e515658acbbb5bfd..0d13046527fdfb5ab0096ce0b72964b635b6a5d5 100644

--- a/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/custom/V8XMLHttpRequestCustom.cpp

@@ -50,9 +50,9 @@ namespace blink {

void V8XMLHttpRequest::responseTextAttributeGetterCustom(

const v8::FunctionCallbackInfo<v8::Value>& info) {

XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toImpl(info.Holder());

- ExceptionState exceptionState(ExceptionState::GetterContext, "responseText",

- "XMLHttpRequest", info.Holder(),

- info.GetIsolate());

+ ExceptionState exceptionState(info.GetIsolate(),

+ ExceptionState::GetterContext, "XMLHttpRequest",

+ "responseText");

ScriptString text = xmlHttpRequest->responseText(exceptionState);

if (text.isEmpty()) {

v8SetReturnValueString(info, emptyString(), info.GetIsolate());

@@ -64,9 +64,9 @@ void V8XMLHttpRequest::responseTextAttributeGetterCustom(

void V8XMLHttpRequest::responseAttributeGetterCustom(

const v8::FunctionCallbackInfo<v8::Value>& info) {

XMLHttpRequest* xmlHttpRequest = V8XMLHttpRequest::toImpl(info.Holder());

- ExceptionState exceptionState(ExceptionState::GetterContext, "response",

- "XMLHttpRequest", info.Holder(),

- info.GetIsolate());

+ ExceptionState exceptionState(info.GetIsolate(),

+ ExceptionState::GetterContext, "XMLHttpRequest",

+ "response");

switch (xmlHttpRequest->getResponseTypeCode()) {

case XMLHttpRequest::ResponseTypeDefault: