Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp

Issue 2566823002: Remove deprecated ExceptionState constructors. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp b/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp
index eb4974e91d06882361bb7a1470c0d82fbb358bd7..5b75d8d6f9c8aabf5eb58789ffaea67ce1c03087 100644
--- a/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/PrivateScriptRunner.cpp
@@ -332,9 +332,8 @@ void rethrowExceptionInPrivateScript(v8::Isolate* isolate,
RELEASE_ASSERT(code->IsInt32());
int exceptionCode = code.As<v8::Int32>()->Value();
ScriptState::Scope scope(scriptStateInUserScript);
- ExceptionState exceptionState(errorContext, propertyName, interfaceName,
- context->Global(),
- scriptStateInUserScript->isolate());
+ ExceptionState exceptionState(scriptStateInUserScript->isolate(),
+ errorContext, interfaceName, propertyName);
exceptionState.throwDOMException(exceptionCode, messageString);
return;
}
@@ -346,9 +345,8 @@ void rethrowExceptionInPrivateScript(v8::Isolate* isolate,
if (exceptionName == "RangeError" &&
messageString.contains("Maximum call stack size exceeded")) {
ScriptState::Scope scope(scriptStateInUserScript);
- ExceptionState exceptionState(errorContext, propertyName, interfaceName,
- scriptStateInUserScript->context()->Global(),
- scriptStateInUserScript->isolate());
+ ExceptionState exceptionState(scriptStateInUserScript->isolate(),
+ errorContext, interfaceName, propertyName);
exceptionState.throwDOMException(V8RangeError, messageString);
return;
}

Powered by Google App Engine
This is Rietveld 408576698