Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 2566513004: This change removes SpdyFramer::set_enable_compression() in favor of a constructor parameter. (Closed)

Created:
4 years ago by Biren Roy
Modified:
4 years ago
Reviewers:
Bence, Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

This change removes SpdyFramer::set_enable_compression() in favor of a constructor parameter. Most of this changelist is just fixing up SpdyFramer constructor call sites and tests. This CL lands server change 141335728 by birenroy. BUG=488484 Committed: https://crrev.com/5a8cd7c774f376bc9f51cceea12aaed1a1edb87e Cr-Commit-Position: refs/heads/master@{#437751}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+187 lines, -209 lines) Patch
M net/quic/chromium/quic_test_packet_maker.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream.cc View 1 chunk +1 line, -0 lines 0 comments Download
M net/quic/core/quic_headers_stream_test.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/quic/core/spdy_utils.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/buffered_spdy_framer.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/spdy/buffered_spdy_framer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/spdy/spdy_deframer_visitor_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M net/spdy/spdy_frame_builder_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/spdy/spdy_framer.h View 4 chunks +11 lines, -7 lines 0 comments Download
M net/spdy/spdy_framer.cc View 5 chunks +8 lines, -6 lines 0 comments Download
M net/spdy/spdy_framer_decoder_adapter.cc View 1 chunk +4 lines, -1 line 0 comments Download
M net/spdy/spdy_framer_test.cc View 123 chunks +139 lines, -181 lines 0 comments Download
M net/spdy/spdy_test_util_common.cc View 4 chunks +8 lines, -4 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (9 generated)
Biren Roy
4 years ago (2016-12-09 23:21:57 UTC) #4
Ryan Hamilton
lgtm
4 years ago (2016-12-10 04:20:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2566513004/1
4 years ago (2016-12-10 04:20:26 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 04:25:13 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 15:06:23 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a8cd7c774f376bc9f51cceea12aaed1a1edb87e
Cr-Commit-Position: refs/heads/master@{#437751}

Powered by Google App Engine
This is Rietveld 408576698