Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: net/spdy/spdy_test_util_common.cc

Issue 2566513004: This change removes SpdyFramer::set_enable_compression() in favor of a constructor parameter. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_test_util_common.cc
diff --git a/net/spdy/spdy_test_util_common.cc b/net/spdy/spdy_test_util_common.cc
index 21d2df12d97b06c2fa51cd77e6e9b41204facf71..913287c34dbc302b01ba2b81eaf464d039b75db3 100644
--- a/net/spdy/spdy_test_util_common.cc
+++ b/net/spdy/spdy_test_util_common.cc
@@ -678,7 +678,11 @@ void SpdySessionPoolPeer::SetEnableSendingInitialData(bool enabled) {
pool_->enable_sending_initial_data_ = enabled;
}
-SpdyTestUtil::SpdyTestUtil() : default_url_(GURL(kDefaultUrl)) {}
+SpdyTestUtil::SpdyTestUtil()
+ : headerless_spdy_framer_(SpdyFramer::ENABLE_COMPRESSION),
+ request_spdy_framer_(SpdyFramer::ENABLE_COMPRESSION),
+ response_spdy_framer_(SpdyFramer::ENABLE_COMPRESSION),
+ default_url_(GURL(kDefaultUrl)) {}
SpdyTestUtil::~SpdyTestUtil() {}
@@ -1044,7 +1048,7 @@ SpdySerializedFrame SpdyTestUtil::ConstructSpdyPostReply(
SpdySerializedFrame SpdyTestUtil::ConstructSpdyDataFrame(int stream_id,
bool fin) {
- SpdyFramer framer;
+ SpdyFramer framer(SpdyFramer::ENABLE_COMPRESSION);
SpdyDataIR data_ir(stream_id,
base::StringPiece(kUploadData, kUploadDataSize));
data_ir.set_fin(fin);
@@ -1055,7 +1059,7 @@ SpdySerializedFrame SpdyTestUtil::ConstructSpdyDataFrame(int stream_id,
const char* data,
uint32_t len,
bool fin) {
- SpdyFramer framer;
+ SpdyFramer framer(SpdyFramer::ENABLE_COMPRESSION);
SpdyDataIR data_ir(stream_id, base::StringPiece(data, len));
data_ir.set_fin(fin);
return SpdySerializedFrame(framer.SerializeData(data_ir));
@@ -1066,7 +1070,7 @@ SpdySerializedFrame SpdyTestUtil::ConstructSpdyDataFrame(int stream_id,
uint32_t len,
bool fin,
int padding_length) {
- SpdyFramer framer;
+ SpdyFramer framer(SpdyFramer::ENABLE_COMPRESSION);
SpdyDataIR data_ir(stream_id, base::StringPiece(data, len));
data_ir.set_fin(fin);
data_ir.set_padding_len(padding_length);
« no previous file with comments | « net/spdy/spdy_framer_test.cc ('k') | net/tools/quic/end_to_end_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698