Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(757)

Side by Side Diff: net/spdy/spdy_frame_builder_test.cc

Issue 2566513004: This change removes SpdyFramer::set_enable_compression() in favor of a constructor parameter. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/spdy/spdy_deframer_visitor_test.cc ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/spdy/spdy_frame_builder.h" 5 #include "net/spdy/spdy_frame_builder.h"
6 6
7 #include "net/spdy/spdy_framer.h" 7 #include "net/spdy/spdy_framer.h"
8 #include "net/spdy/spdy_protocol.h" 8 #include "net/spdy/spdy_protocol.h"
9 #include "testing/platform_test.h" 9 #include "testing/platform_test.h"
10 10
11 namespace net { 11 namespace net {
12 12
13 TEST(SpdyFrameBuilderTest, GetWritableBuffer) { 13 TEST(SpdyFrameBuilderTest, GetWritableBuffer) {
14 const size_t kBuilderSize = 10; 14 const size_t kBuilderSize = 10;
15 SpdyFrameBuilder builder(kBuilderSize); 15 SpdyFrameBuilder builder(kBuilderSize);
16 char* writable_buffer = builder.GetWritableBuffer(kBuilderSize); 16 char* writable_buffer = builder.GetWritableBuffer(kBuilderSize);
17 memset(writable_buffer, ~1, kBuilderSize); 17 memset(writable_buffer, ~1, kBuilderSize);
18 EXPECT_TRUE(builder.Seek(kBuilderSize)); 18 EXPECT_TRUE(builder.Seek(kBuilderSize));
19 SpdySerializedFrame frame(builder.take()); 19 SpdySerializedFrame frame(builder.take());
20 char expected[kBuilderSize]; 20 char expected[kBuilderSize];
21 memset(expected, ~1, kBuilderSize); 21 memset(expected, ~1, kBuilderSize);
22 EXPECT_EQ(base::StringPiece(expected, kBuilderSize), 22 EXPECT_EQ(base::StringPiece(expected, kBuilderSize),
23 base::StringPiece(frame.data(), kBuilderSize)); 23 base::StringPiece(frame.data(), kBuilderSize));
24 } 24 }
25 25
26 TEST(SpdyFrameBuilderTest, RewriteLength) { 26 TEST(SpdyFrameBuilderTest, RewriteLength) {
27 // Create an empty SETTINGS frame both via framer and manually via builder. 27 // Create an empty SETTINGS frame both via framer and manually via builder.
28 // The one created via builder is initially given the incorrect length, but 28 // The one created via builder is initially given the incorrect length, but
29 // then is corrected via RewriteLength(). 29 // then is corrected via RewriteLength().
30 SpdyFramer framer; 30 SpdyFramer framer(SpdyFramer::ENABLE_COMPRESSION);
31 SpdySettingsIR settings_ir; 31 SpdySettingsIR settings_ir;
32 SpdySerializedFrame expected(framer.SerializeSettings(settings_ir)); 32 SpdySerializedFrame expected(framer.SerializeSettings(settings_ir));
33 SpdyFrameBuilder builder(expected.size() + 1); 33 SpdyFrameBuilder builder(expected.size() + 1);
34 builder.BeginNewFrame(framer, SETTINGS, 0, 0); 34 builder.BeginNewFrame(framer, SETTINGS, 0, 0);
35 EXPECT_TRUE(builder.GetWritableBuffer(1) != NULL); 35 EXPECT_TRUE(builder.GetWritableBuffer(1) != NULL);
36 builder.RewriteLength(framer); 36 builder.RewriteLength(framer);
37 SpdySerializedFrame built(builder.take()); 37 SpdySerializedFrame built(builder.take());
38 EXPECT_EQ(base::StringPiece(expected.data(), expected.size()), 38 EXPECT_EQ(base::StringPiece(expected.data(), expected.size()),
39 base::StringPiece(built.data(), expected.size())); 39 base::StringPiece(built.data(), expected.size()));
40 } 40 }
41 41
42 TEST(SpdyFrameBuilderTest, OverwriteFlags) { 42 TEST(SpdyFrameBuilderTest, OverwriteFlags) {
43 // Create a HEADERS frame both via framer and manually via builder with 43 // Create a HEADERS frame both via framer and manually via builder with
44 // different flags set, then make them match using OverwriteFlags(). 44 // different flags set, then make them match using OverwriteFlags().
45 SpdyFramer framer; 45 SpdyFramer framer(SpdyFramer::ENABLE_COMPRESSION);
46 SpdyHeadersIR headers_ir(1); 46 SpdyHeadersIR headers_ir(1);
47 SpdySerializedFrame expected(framer.SerializeHeaders(headers_ir)); 47 SpdySerializedFrame expected(framer.SerializeHeaders(headers_ir));
48 SpdyFrameBuilder builder(expected.size()); 48 SpdyFrameBuilder builder(expected.size());
49 builder.BeginNewFrame(framer, HEADERS, 0, 1); 49 builder.BeginNewFrame(framer, HEADERS, 0, 1);
50 builder.OverwriteFlags(framer, HEADERS_FLAG_END_HEADERS); 50 builder.OverwriteFlags(framer, HEADERS_FLAG_END_HEADERS);
51 SpdySerializedFrame built(builder.take()); 51 SpdySerializedFrame built(builder.take());
52 EXPECT_EQ(base::StringPiece(expected.data(), expected.size()), 52 EXPECT_EQ(base::StringPiece(expected.data(), expected.size()),
53 base::StringPiece(built.data(), built.size())); 53 base::StringPiece(built.data(), built.size()));
54 } 54 }
55 } // namespace net 55 } // namespace net
OLDNEW
« no previous file with comments | « net/spdy/spdy_deframer_visitor_test.cc ('k') | net/spdy/spdy_framer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698