Convert utility process out-of-process file patching to mojo

Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, patch_file) and patch them: checks
the patched output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them, we use chrome::mojom::FilePatcher instead.

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325
Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
Cr-Commit-Position: refs/heads/master@{#440601}

[Noel Gordon, 2016-12-12 04:53:37]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 04:53:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 05:05:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 05:05:29]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Noel Gordon, 2016-12-12 06:13:24]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 06:13:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 06:28:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 06:28:24]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[Noel Gordon, 2016-12-12 21:52:04]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 21:53:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Noel Gordon, 2016-12-12 22:41:41]

Patchset #3 (id:40001) has been deleted

[Noel Gordon, 2016-12-12 22:41:57]

Patchset #3 (id:60001) has been deleted

[Noel Gordon, 2016-12-12 22:42:11]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 22:43:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-12 23:47:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 23:47:58]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Noel Gordon, 2016-12-13 03:21:19]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-13 03:22:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Noel Gordon, 2016-12-13 03:24:41]

Description was changed from

==========
Mojoify utility process IPC for file patching

BUG=
==========

to

==========
Mojoify utility process IPC for file patching

BUG=597124
==========

[commit-bot: I haz the power, 2016-12-13 04:25:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-13 04:25:17]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2016-12-15 04:54:49]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 04:55:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 05:18:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 05:18:10]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Noel Gordon, 2016-12-15 05:58:23]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 05:58:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 06:11:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 06:11:14]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Noel Gordon, 2016-12-15 06:19:58]

Patchset #5 (id:120001) has been deleted

[Noel Gordon, 2016-12-15 06:20:08]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 06:20:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Noel Gordon, 2016-12-15 06:50:58]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 06:51:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-15 07:47:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 07:47:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Noel Gordon, 2016-12-15 11:06:58]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 11:07:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Noel Gordon, 2016-12-15 11:11:45]

Patchset #7 (id:180001) has been deleted

[commit-bot: I haz the power, 2016-12-15 11:12:50]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[commit-bot: I haz the power, 2016-12-15 12:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 12:04:39]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Noel Gordon, 2016-12-15 23:52:55]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-15 23:53:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 00:34:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 00:34:44]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Noel Gordon, 2016-12-16 01:22:10]

Patchset #7 (id:200001) has been deleted

[Noel Gordon, 2016-12-16 01:23:53]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 01:24:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 02:29:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 02:29:17]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Noel Gordon, 2016-12-16 04:47:47]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-16 04:48:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 05:00:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 05:00:13]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Noel Gordon, 2016-12-20 06:43:05]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 06:43:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 07:45:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 07:45:36]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Noel Gordon, 2016-12-20 11:08:27]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 11:08:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 11:49:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 11:49:02]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2016-12-20 12:16:03]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 12:16:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 12:34:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 12:34:22]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Noel Gordon, 2016-12-20 14:35:14]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 14:35:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Noel Gordon, 2016-12-20 14:36:37]

Patchset #11 (id:300001) has been deleted

[commit-bot: I haz the power, 2016-12-20 14:37:46]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Noel Gordon, 2016-12-20 14:38:36]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 14:38:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-20 15:30:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-20 15:30:43]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2016-12-20 23:47:27]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-20 23:48:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 01:28:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 01:28:17]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2016-12-21 01:39:06]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 01:39:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 03:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 03:44:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Noel Gordon, 2016-12-21 06:21:45]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 06:22:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 06:28:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 06:28:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Noel Gordon, 2016-12-21 09:02:55]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 09:03:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 09:10:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 09:10:35]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Noel Gordon, 2016-12-21 09:35:07]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 09:35:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 10:18:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 10:18:31]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Noel Gordon, 2016-12-21 10:40:41]

Patchset #14 (id:380001) has been deleted

[Noel Gordon, 2016-12-21 10:41:53]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-21 10:42:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-21 12:43:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-21 12:43:30]

Dry run: This issue passed the CQ dry run.

[Noel Gordon, 2016-12-21 15:05:34]

noel@chromium.org changed reviewers:
+ dcheng@chromium.org, jochen@chromium.org, sammc@chromium.org

[Noel Gordon, 2016-12-21 15:05:35]

Right green bots finally.  The out-of-process patcher did not have tests per
https://codereview.chromium.org/2597513003 so added one here.

+jochen for OWNERS.
+daniel for IPC sec review.
+sam for the rest.

PTAL.

[Noel Gordon, 2016-12-22 02:19:35]

noel@chromium.org changed reviewers:
+ tibell@chromium.org

[Noel Gordon, 2016-12-22 02:19:36]

+ Johan for mojo as well. PTAL.

[Sam McNally, 2016-12-22 02:45:49]

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
(right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.cc:18:
#include "courgette/courgette.h"
I think these can go.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.cc:35:
task_runner_ = task_runner;
DCHECK(!utility_process_mojo_client_)
DCHECK(task_runner)

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.cc:75:
if (task_runner_.get()) {
This shouldn't be necessary with utility_process_mojo_client_.reset() above.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process.h
(left):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.h:8:
#include <string>
These are still needed.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.h:16:
class FilePath;
So are these.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process.h
(right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.h:20:
// DeltaUpdateOpPatch::OutOfProcessPatcher::Patch() request.
This comment should be something of the form update_client::OutOfProcessPatcher
overrides or update_client::OutOfProcessPatcher implementation.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc
(right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:8:
#include "base/files/file.h"
Remove.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:21:
#include "courgette/courgette.h"
Remove these.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:32:
static base::FilePath test_file(const char* name) {
Prefer passing these as base::StringPiece.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:73:
void PatchTest(const std::string& operation,
How about RunPatchTest?

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:107:
base::ScopedTempDir installed_dir_;
What do these names mean? Could this test use a single shared tempdir?

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:123:
PatchTest("courgette", input_file, patch_file, output_file, kExpectedResult);
Use the constants for the operation argument.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:139:
}
How about adding tests where opening input or output files fails?

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
chrome/utility/chrome_content_utility_client.cc:69: FilePatcherImpl() {}
= default;

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
chrome/utility/chrome_content_utility_client.cc:70: ~FilePatcherImpl() override
{}
= default;

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
chrome/utility/chrome_content_utility_client.cc:258: bool Send(IPC::Message*
message) {
These should remain in the anonymous namespace.

[tibell, 2016-12-22 02:59:39]

https://codereview.chromium.org/2566053002/diff/400001/chrome/common/file_pat...
File chrome/common/file_patcher.mojom (right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/common/file_pat...
chrome/common/file_patcher.mojom:15: // Returns |result| bsdiff::OK on success.
Nit: perhaps worth saying that |result| is a |bsdiff::BSDiffStatus|.

https://codereview.chromium.org/2566053002/diff/400001/chrome/common/file_pat...
chrome/common/file_patcher.mojom:27: mojo.common.mojom.File output_file) =>
(int32 result);
Nit: perhaps worth saying that |result| is a |courgette::Status|.

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
chrome/utility/chrome_content_utility_client.cc:78: void
PatchFileBsdiff(base::File input_file,
We usually add line

// chrome::mojom::FilePatcher:

before the overrides so it's clear where they're coming.

[Noel Gordon, 2016-12-22 04:38:24]

On 2016/12/22 02:59:39, tibell wrote:
>
https://codereview.chromium.org/2566053002/diff/400001/chrome/common/file_pat...
> File chrome/common/file_patcher.mojom (right):
> 
>
https://codereview.chromium.org/2566053002/diff/400001/chrome/common/file_pat...
> chrome/common/file_patcher.mojom:15: // Returns |result| bsdiff::OK on
success.
> Nit: perhaps worth saying that |result| is a |bsdiff::BSDiffStatus|.
> 
>
https://codereview.chromium.org/2566053002/diff/400001/chrome/common/file_pat...
> chrome/common/file_patcher.mojom:27: mojo.common.mojom.File output_file) =>
> (int32 result);
> Nit: perhaps worth saying that |result| is a |courgette::Status|.

Done.

>
https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
> File chrome/utility/chrome_content_utility_client.cc (right):
> 
>
https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
> chrome/utility/chrome_content_utility_client.cc:78: void
> PatchFileBsdiff(base::File input_file,
> We usually add line

Done.

> // chrome::mojom::FilePatcher:
> 
> before the overrides so it's clear where they're coming.

Done.

[tibell, 2016-12-22 05:02:33]

lgtm

[Noel Gordon, 2016-12-22 05:06:34]

New patch uploaded.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process.cc
(right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.cc:18:
#include "courgette/courgette.h"
On 2016/12/22 02:45:48, Sam McNally wrote:
> I think these can go.

Done.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.cc:35:
task_runner_ = task_runner;
On 2016/12/22 02:45:48, Sam McNally wrote:
> DCHECK(!utility_process_mojo_client_)
> DCHECK(task_runner)

Done. And moved all DCHECK to here.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.cc:75:
if (task_runner_.get()) {
On 2016/12/22 02:45:49, Sam McNally wrote:
> This shouldn't be necessary with utility_process_mojo_client_.reset() above.

Done.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process.h
(left):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.h:8:
#include <string>
On 2016/12/22 02:45:49, Sam McNally wrote:
> These are still needed.

OK, let's do IWYU herein, and remove duplicate #include from the .cc file.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.h:16:
class FilePath;
On 2016/12/22 02:45:49, Sam McNally wrote:
> So are these.

Ditto.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process.h
(right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process.h:20:
// DeltaUpdateOpPatch::OutOfProcessPatcher::Patch() request.
On 2016/12/22 02:45:49, Sam McNally wrote:
> This comment should be something of the form
update_client::OutOfProcessPatcher
> overrides or update_client::OutOfProcessPatcher implementation.

// update_client::OutOfProcessPatcher

done.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc
(right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:8:
#include "base/files/file.h"
On 2016/12/22 02:45:49, Sam McNally wrote:
> Remove.

Kept.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:21:
#include "courgette/courgette.h"
On 2016/12/22 02:45:49, Sam McNally wrote:
> Remove these.

Yes, good spot, done.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:32:
static base::FilePath test_file(const char* name) {
On 2016/12/22 02:45:49, Sam McNally wrote:
> Prefer passing these as base::StringPiece.

This code came from the update_client unit tests.  Hoping the folks over there
will take ownership of the current test, so I'd like to retain the code they
use.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:73:
void PatchTest(const std::string& operation,
On 2016/12/22 02:45:49, Sam McNally wrote:
> How about RunPatchTest?

Done.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:107:
base::ScopedTempDir installed_dir_;
On 2016/12/22 02:45:49, Sam McNally wrote:
> What do these names mean? Could this test use a single shared tempdir?

Great question (had the same question myself about meaning), /me guesses 

    installed_dir_  -- chrome install directory.
    input_dir_ -- directory where the patch file was downloaded.
    output_dir_ -- directory where the patched result should be written.

Still these dir_ names again come from the update_client unittests, so I just
used their names to make things easier for them to take over this test.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:123:
PatchTest("courgette", input_file, patch_file, output_file, kExpectedResult);
On 2016/12/22 02:45:49, Sam McNally wrote:
> Use the constants for the operation argument.

Yes, done here and in CheckBsdiffOperation below.  Used the constants defined
for operations from namespace update_client::

Added a TODO re: adding a test with one of files that can't be opened.

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:139:
}
On 2016/12/22 02:45:49, Sam McNally wrote:
> How about adding tests where opening input or output files fails?

Added a TODO about this.

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
File chrome/utility/chrome_content_utility_client.cc (right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
chrome/utility/chrome_content_utility_client.cc:69: FilePatcherImpl() {}
On 2016/12/22 02:45:49, Sam McNally wrote:
> = default;

Done.

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
chrome/utility/chrome_content_utility_client.cc:70: ~FilePatcherImpl() override
{}
On 2016/12/22 02:45:49, Sam McNally wrote:
> = default;

Done.

https://codereview.chromium.org/2566053002/diff/400001/chrome/utility/chrome_...
chrome/utility/chrome_content_utility_client.cc:258: bool Send(IPC::Message*
message) {
On 2016/12/22 02:45:49, Sam McNally wrote:
> These should remain in the anonymous namespace.

Done.

[Noel Gordon, 2016-12-22 05:06:48]

The CQ bit was checked by noel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-22 05:07:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Sam McNally, 2016-12-22 05:12:48]

lgtm

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
File
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc
(right):

https://codereview.chromium.org/2566053002/diff/400001/chrome/browser/compone...
chrome/browser/component_updater/component_patcher_operation_out_of_process_browsertest.cc:21:
#include "courgette/courgette.h"
On 2016/12/22 05:06:33, noel gordon wrote:
> On 2016/12/22 02:45:49, Sam McNally wrote:
> > Remove these.
> 
> Yes, good spot, done.

They're still there.

[Noel Gordon, 2016-12-22 05:23:01]

On 2016/12/22 05:12:48, Sam McNally wrote:
> They're still there.

Oh yes, sorry.  Forgot to mention they do need to be there since they are used

 119   const int kExpectedResult = courgette::C_OK;
 133   const int kExpectedResult = bsdiff::OK;

The browertest.cc won't compile without these includes, testing locally.

[commit-bot: I haz the power, 2016-12-22 06:02:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-22 06:02:43]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-12-22 07:44:42]

mojo lgtm

[jochen (gone - plz use gerrit), 2016-12-22 16:00:48]

lgtm

[Noel Gordon, 2016-12-23 06:43:11]

Description was changed from

==========
Mojoify utility process IPC for file patching

BUG=597124
==========

to

==========
Mojoify utility process IPC for file patching

BUG=597124, 660325
==========

[Noel Gordon, 2016-12-23 06:45:42]

Description was changed from

==========
Mojoify utility process IPC for file patching

BUG=597124, 660325
==========

to

==========
Convert utility process file patching to mojo.

BUG=597124, 660325
==========

[Noel Gordon, 2016-12-23 07:24:57]

Description was changed from

==========
Convert utility process file patching to mojo.

BUG=597124, 660325
==========

to

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, output_file) and patch them: check
the patch output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them (we use chrome::mojom::FilePatcher instead).

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromim.org
BUG=597124, 660325
==========

[Noel Gordon, 2016-12-23 07:25:22]

Description was changed from

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, output_file) and patch them: check
the patch output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them (we use chrome::mojom::FilePatcher instead).

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromim.org
BUG=597124, 660325
==========

to

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, output_file) and patch them: check
the patch output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them (we use chrome::mojom::FilePatcher instead).

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325
==========

[Noel Gordon, 2016-12-23 07:27:11]

TBR=waffles@chromium.org for content_updater, but OOO at the moment.

[Noel Gordon, 2016-12-23 07:27:30]

noel@chromium.org changed reviewers:
+ waffles@chromium.org

[Noel Gordon, 2016-12-23 07:27:46]

The CQ bit was checked by noel@chromium.org

[Noel Gordon, 2016-12-23 07:27:46]

The patchset sent to the CQ was uploaded after l-g-t-m from tibell@chromium.org
Link to the patchset: https://codereview.chromium.org/2566053002/#ps420001
(title: "Address review comments.")

[commit-bot: I haz the power, 2016-12-23 07:27:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Noel Gordon, 2016-12-23 07:30:14]

Description was changed from

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, output_file) and patch them: check
the patch output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them (we use chrome::mojom::FilePatcher instead).

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325
==========

to

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, patch_file) and patch them: checks
the patched output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them (we use chrome::mojom::FilePatcher instead).

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325
==========

[Noel Gordon, 2016-12-23 07:30:48]

Description was changed from

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, patch_file) and patch them: checks
the patched output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them (we use chrome::mojom::FilePatcher instead).

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325
==========

to

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, patch_file) and patch them: checks
the patched output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them, we use chrome::mojom::FilePatcher instead.

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325
==========

[Noel Gordon, 2016-12-23 07:31:49]

noel@chromium.org changed reviewers:
+ sorin@chromium.org

[commit-bot: I haz the power, 2016-12-23 08:28:51]

CQ is committing da patch.

Bot data: {"patchset_id": 420001, "attempt_start_ts": 1482478066074060,
"parent_rev": "b226c71fbd3c5d558caf79647e52f422eb262b27", "commit_rev":
"1dee1469542da77717fca39ffc3918fbc51ce448"}

[commit-bot: I haz the power, 2016-12-23 08:29:21]

Description was changed from

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, patch_file) and patch them: checks
the patched output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them, we use chrome::mojom::FilePatcher instead.

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325
==========

to

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, patch_file) and patch them: checks
the patched output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them, we use chrome::mojom::FilePatcher instead.

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325

Review-Url: https://codereview.chromium.org/2566053002
==========

[commit-bot: I haz the power, 2016-12-23 08:29:24]

Committed patchset #15 (id:420001)

[commit-bot: I haz the power, 2016-12-23 08:32:02]

Description was changed from

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, patch_file) and patch them: checks
the patched output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them, we use chrome::mojom::FilePatcher instead.

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325

Review-Url: https://codereview.chromium.org/2566053002
==========

to

==========
Convert utility process out-of-process file patching to mojo

Define interface chrome::mojom::FilePatcher for out-of-process file
patching. Add that interface to the utility process, and expose the
interface to the browser process by mojo policy [1].

ChromeOutOfProcessPatcher: remove PatchHost() helper class, replace
it with a content::UtilityProcessMojoClient() and use that to start
and stop the utility process needed for out-of-process file patches
and to perform out-of-process file patches using mojo calls, rather
than IPC::Send().

Add a in-process browser test for the ChromeOutOfProcessPatcher (it
had no tests http://bit.ly/2h8mafX it seems). Copy the golden files
to random locations (input_file, patch_file) and patch them: checks
the patched output_file matches the golden output file.

Delete all the IPC related to out-of-process file patching since we
no longer use them, we use chrome::mojom::FilePatcher instead.

[1] chrome_content_utility_manifest_overlay.json

TBR=waffles@chromium.org
BUG=597124, 660325

Committed: https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
Cr-Commit-Position: refs/heads/master@{#440601}
==========

[commit-bot: I haz the power, 2016-12-23 08:32:04]

Patchset 15 (id:??) landed as
https://crrev.com/32afc44b332255130c247e3bfc4a27261d11ddfb
Cr-Commit-Position: refs/heads/master@{#440601}

[Will Harris, 2016-12-25 20:25:08]

A revert of this CL (patchset #15 id:420001) has been created in
https://codereview.chromium.org/2599393002/ by wfh@chromium.org.

The reason for reverting is: broke component updater - see crbug.com/676960.