Convert utility process out-of-process file patching to mojo

chrome/browser/component_updater/component_patcher_operation_out_of_process.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_PATCHER_OPERATION_OUT_OF_PROCESS_H_
 #define CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_PATCHER_OPERATION_OUT_OF_PROCESS_H_
 
-#include <string>

[Sam McNally, 2016/12/22 02:45:49]

These are still needed.

[Noel Gordon, 2016/12/22 05:06:33]

OK, let's do IWYU herein, and remove duplicate #include from the .cc file.

-
-#include "base/callback_forward.h"
 #include "base/macros.h"
-#include "base/memory/ref_counted.h"
+#include "chrome/common/file_patcher.mojom.h"
 #include "components/update_client/component_patcher_operation.h"
-
-namespace base {
-class FilePath;

[Sam McNally, 2016/12/22 02:45:49]

So are these.

[Noel Gordon, 2016/12/22 05:06:33]

Ditto.

-class SequencedTaskRunner;
-}  // namespace base
+#include "content/public/browser/utility_process_mojo_client.h"
 
 namespace component_updater {
 
-class PatchHost;
-
 // Implements the DeltaUpdateOpPatch out-of-process patching.
 class ChromeOutOfProcessPatcher : public update_client::OutOfProcessPatcher {
  public:
   ChromeOutOfProcessPatcher();
 
-  // DeltaUpdateOpPatch::OutOfProcessPatcher implementation.
+  // DeltaUpdateOpPatch::OutOfProcessPatcher::Patch() request.

[Sam McNally, 2016/12/22 02:45:49]

This comment should be something of the form update_client::OutOfProcessPatcher
overrides or update_client::OutOfProcessPatcher implementation.

[Noel Gordon, 2016/12/22 05:06:33]

// update_client::OutOfProcessPatcher

done.

   void Patch(const std::string& operation,
              scoped_refptr<base::SequencedTaskRunner> task_runner,
              const base::FilePath& input_abs_path,
              const base::FilePath& patch_abs_path,
              const base::FilePath& output_abs_path,
              base::Callback<void(int result)> callback) override;
 
  private:
   ~ChromeOutOfProcessPatcher() override;
 
-  scoped_refptr<PatchHost> host_;
+  // Patch() request operation result.
+  void PatchDone(int result);
+
+  // Used to signal the operation result back to the Patch() requester.
+  scoped_refptr<base::SequencedTaskRunner> task_runner_;
+  base::Callback<void(int result)> callback_;
+
+  // Utility process used for out-of-process file patching.
+  std::unique_ptr<content::UtilityProcessMojoClient<chrome::mojom::FilePatcher>>
+      utility_process_mojo_client_;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeOutOfProcessPatcher);
 };
 
 }  // namespace component_updater
 
 #endif  // CHROME_BROWSER_COMPONENT_UPDATER_COMPONENT_PATCHER_OPERATION_OUT_OF_PROCESS_H_