Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 25657008: Only have one method for generating a method. (Closed)

Created:
7 years, 2 months ago by ahe
Modified:
7 years, 2 months ago
Reviewers:
kasperl, sra1
CC:
reviews_dartlang.org, ngeoffray
Visibility:
Public.

Description

Only have one method for generating a method. R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=28199

Patch Set 1 : #

Total comments: 4

Patch Set 2 : Change name of writeOn to make it absolutely clear that it shouldn't be used in normal situations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -112 lines) Patch
M dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_builder.dart View 1 1 chunk +11 lines, -0 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart View 1 6 chunks +10 lines, -112 lines 0 comments Download
M dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart View 1 chunk +82 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
ahe
7 years, 2 months ago (2013-10-02 15:40:31 UTC) #1
sra1
DBC Do you expect to be done with the code churn soon? I have to ...
7 years, 2 months ago (2013-10-02 16:10:52 UTC) #2
ahe
Hi Stephen, Sorry for all the churn :-) I'm done moving files around, but more ...
7 years, 2 months ago (2013-10-02 16:58:05 UTC) #3
kasperl
LGTM. https://codereview.chromium.org/25657008/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart File dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/25657008/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart#newcode2008 dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:2008: bufferForElement(element, eagerBuffer), compiler, ',$n$n'); Nit: I'd compute the ...
7 years, 2 months ago (2013-10-03 07:08:36 UTC) #4
ahe
Thank you! https://codereview.chromium.org/25657008/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart File dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart (right): https://codereview.chromium.org/25657008/diff/3001/dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart#newcode2008 dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart:2008: bufferForElement(element, eagerBuffer), compiler, ',$n$n'); On 2013/10/03 07:08:37, ...
7 years, 2 months ago (2013-10-03 07:20:17 UTC) #5
ahe
7 years, 2 months ago (2013-10-03 08:56:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r28199 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698