dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart - Issue 25657008: Only have one method for generating a method.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 25657008: Only have one method for generating a method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge

Patch Set: Change name of writeOn to make it absolutely clear that it shouldn't be used in normal situations. Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

index 9bee82c151e77463d8382fcdadc732baddcda679..f11ac3be014f6f8802e9e12069e67d010c32e3bb 100644

--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

@@ -802,10 +802,14 @@ class Namer implements ClosureNamer {

String getNameOfField(VariableElement field) => getNameX(field);

+ // TODO(ahe): Remove this method. Use get getNameOfMember instead.

String getNameOfInstanceMember(Element member) => getNameX(member);

+ String getNameOfMember(Element member) => getNameX(member);

String getNameOfGlobalField(VariableElement field) => getNameX(field);

+ // TODO(ahe): Remove this method. Use get getNameOfMember instead.

String getNameOfGlobalFunction(FunctionElement element) => getNameX(element);

/// Returns true if [element] is stored on CURRENT_ISOLATE ('$'). We intend

« no previous file with comments | « no previous file | dart/sdk/lib/_internal/compiler/implementation/js_emitter/class_builder.dart » ('j') | no next file with comments »