Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart

Issue 25657008: Only have one method for generating a method. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Change name of writeOn to make it absolutely clear that it shouldn't be used in normal situations. Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
index 6c1853fffdea0117c1631922ed420374666f129f..15ad85a191f6d94195b9828922d5a549d8a6368d 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_emitter/container_builder.dart
@@ -593,4 +593,86 @@ class ContainerBuilder {
}
}
}
+
+ void addMember(Element member, ClassBuilder builder) {
+ assert(invariant(member, member.isDeclaration));
+
+ if (member.isField()) {
+ addMemberField(member, builder);
+ } else if (member.isFunction() ||
+ member.isGenerativeConstructorBody() ||
+ member.isGenerativeConstructor() ||
+ member.isAccessor()) {
+ addMemberMethod(member, builder);
+ } else {
+ compiler.internalErrorOnElement(
+ member, 'unexpected kind: "${member.kind}"');
+ }
+ if (member.isInstanceMember()) emitExtraAccessors(member, builder);
+ }
+
+ void addMemberMethod(FunctionElement member, ClassBuilder builder) {
+ if (member.isAbstract(compiler)) return;
+ jsAst.Expression code = backend.generatedCode[member];
+ if (code == null) return;
+ String name = namer.getNameOfMember(member);
+ if (backend.isInterceptedMethod(member)) {
+ task.interceptorInvocationNames.add(name);
+ }
+ code = extendWithMetadata(member, code);
+ builder.addProperty(name, code);
+ String reflectionName = task.getReflectionName(member, name);
+ if (reflectionName != null) {
+ var reflectable =
+ js(backend.isAccessibleByReflection(member) ? '1' : '0');
+ builder.addProperty('+$reflectionName', reflectable);
+ jsAst.Node defaultValues = task.reifyDefaultArguments(member);
+ if (defaultValues != null) {
+ String unmangledName = member.name.slowToString();
+ builder.addProperty('*$unmangledName', defaultValues);
+ }
+ }
+ code = backend.generatedBailoutCode[member];
+ if (code != null) {
+ builder.addProperty(namer.getBailoutName(member), code);
+ }
+ if (member.isInstanceMember()) {
+ // TODO(ahe): Where is this done for static/top-level methods?
+ FunctionSignature parameters = member.computeSignature(compiler);
+ if (!parameters.optionalParameters.isEmpty) {
+ addParameterStubs(member, builder.addProperty);
+ }
+ }
+ }
+
+ void addMemberField(VariableElement member, ClassBuilder builder) {
+ // For now, do nothing.
+ }
+
+ jsAst.Fun extendWithMetadata(FunctionElement element, jsAst.Fun code) {
+ if (!backend.retainMetadataOf(element)) return code;
+ return compiler.withCurrentElement(element, () {
+ List<int> metadata = <int>[];
+ FunctionSignature signature = element.functionSignature;
+ if (element.isConstructor()) {
+ metadata.add(task.reifyType(element.getEnclosingClass().thisType));
+ } else {
+ metadata.add(task.reifyType(signature.returnType));
+ }
+ signature.forEachParameter((Element parameter) {
+ metadata
+ ..add(task.reifyName(parameter.name))
+ ..add(task.reifyType(parameter.computeType(compiler)));
+ });
+ Link link = element.metadata;
+ // TODO(ahe): Why is metadata sometimes null?
+ if (link != null) {
+ for (; !link.isEmpty; link = link.tail) {
+ metadata.add(task.reifyMetadata(link.head));
+ }
+ }
+ code.body.statements.add(js.string(metadata.join(',')).toStatement());
+ return code;
+ });
+ }
}
« no previous file with comments | « dart/sdk/lib/_internal/compiler/implementation/js_emitter/code_emitter_task.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698