Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2565043002: Add flags entry to enable Chrome OS component updates fature. (Closed)

Created:
4 years ago by Greg K
Modified:
4 years ago
Reviewers:
waffles, Steven Holte
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add flags entry to enable Chrome OS component updates fature. This adds an entry to about:flags so that users, and internal testers, can opt into Chrome OS component updates before we roll them out to all users. This was originally landed in https://codereview.chromium.org/2544133002, but reverted in https://codereview.chromium.org/2567773002 because one of the other flags did not work properly. BUG=670421 Committed: https://crrev.com/22db7c938623cc9e8b2308a715dd44645dac0a98 Cr-Commit-Position: refs/heads/master@{#437774}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (13 generated)
Greg K
PTAL Thanks, Greg
4 years ago (2016-12-10 00:26:34 UTC) #4
waffles
lgtm Consider linking to the original CL and revert in the CL description.
4 years ago (2016-12-10 00:30:48 UTC) #5
Greg K
On 2016/12/10 00:30:48, waffles wrote: > lgtm > > Consider linking to the original CL ...
4 years ago (2016-12-10 00:35:40 UTC) #9
Steven Holte
lgtm
4 years ago (2016-12-10 01:04:05 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565043002/1
4 years ago (2016-12-10 01:29:19 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: cast_shell_linux on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_asan_rel_ng on ...
4 years ago (2016-12-10 02:26:17 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2565043002/1
4 years ago (2016-12-10 18:56:50 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 19:10:15 UTC) #20
commit-bot: I haz the power
4 years ago (2016-12-12 15:07:12 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/22db7c938623cc9e8b2308a715dd44645dac0a98
Cr-Commit-Position: refs/heads/master@{#437774}

Powered by Google App Engine
This is Rietveld 408576698