Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 2567773002: Revert "Add flags entries to test chrome OS component updates in release mode." (Closed)

Created:
4 years ago by Greg K
Modified:
4 years ago
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Add flags entries to test chrome OS component updates in release mode." This reverts commit 658a3dc11300924b70ac3097922b8ae0cd632798, which did not work-as-intended because the Chrome feature flags are not available at the time of zygote initialization. BUG=670421 TBR=asvitkine@chromium.org Committed: https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514 Cr-Commit-Position: refs/heads/master@{#437697}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -47 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +0 lines, -14 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/component_updater/pepper_flash_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_content_client.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/common/chrome_features.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/chrome_features.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 4 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 20 (13 generated)
Greg K
PTAL Thanks, Greg
4 years ago (2016-12-09 20:03:24 UTC) #3
waffles
lgtm
4 years ago (2016-12-09 21:14:10 UTC) #7
Greg K
thakis@chromium.org: Please review changes in chrome/common/chrome_content_client.cc Thanks, Greg
4 years ago (2016-12-09 21:15:22 UTC) #9
Nico
lgtm
4 years ago (2016-12-09 21:17:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2567773002/1
4 years ago (2016-12-09 23:12:22 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-09 23:40:51 UTC) #18
commit-bot: I haz the power
4 years ago (2016-12-12 14:58:33 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a12878e02ab6c986cb099f7bce554b39305fa514
Cr-Commit-Position: refs/heads/master@{#437697}

Powered by Google App Engine
This is Rietveld 408576698