Add flags entries to test chrome OS component updates in release mode.

Add flags entries to test chrome OS component updates in release mode.

This adds two new flags to chrome://flags so that component updates, on
Chrome OS, can be tested in release mode. The flags enable flash
updates for Chrome OS (currently a finch experiment), and enable only
component flash in the browswer (disabling the system plugin).

BUG=670421
Committed: https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798
Cr-Commit-Position: refs/heads/master@{#436646}

[Greg K, 2016-12-01 22:59:49]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-01 23:00:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Greg K, 2016-12-01 23:15:07]

kerrnel@chromium.org changed reviewers:
+ waffles@chromium.org

[Greg K, 2016-12-01 23:15:07]

PTAL

Thanks,

Greg

[waffles, 2016-12-01 23:51:18]

lgtm w/ comment to discuss

https://codereview.chromium.org/2544133002/diff/1/chrome/common/chrome_conten...
File chrome/common/chrome_content_client.cc (right):

https://codereview.chromium.org/2544133002/diff/1/chrome/common/chrome_conten...
chrome/common/chrome_content_client.cc:511: return;
I think it might be cleaner to instead do something like:

#if defined(OS_CHROMEOS)
if (base::FeatureList::IsEnabled(features::kComponentFlashOnly))
  return;
#endif

in the body of GetCommandLinePepperFlash, what do you think?

I agree it puts this override less front-and-center, but in practice
SystemPepperFlash doesn't exist on Linux, and I'm slightly worried about
short-circuiting the "fake Flash plugin" if  GetComponentUpdatedPepperFlash
returns false.

[commit-bot: I haz the power, 2016-12-02 00:04:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 00:04:28]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Greg K, 2016-12-02 01:06:12]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[Greg K, 2016-12-02 01:06:26]

Ok, PTAL and let me know if this is still LGTM.

Thanks,

Greg

https://codereview.chromium.org/2544133002/diff/1/chrome/common/chrome_conten...
File chrome/common/chrome_content_client.cc (right):

https://codereview.chromium.org/2544133002/diff/1/chrome/common/chrome_conten...
chrome/common/chrome_content_client.cc:511: return;
On 2016/12/01 23:51:18, waffles wrote:
> I think it might be cleaner to instead do something like:
> 
> #if defined(OS_CHROMEOS)
> if (base::FeatureList::IsEnabled(features::kComponentFlashOnly))
>   return;
> #endif
> 
> in the body of GetCommandLinePepperFlash, what do you think?
> 
> I agree it puts this override less front-and-center, but in practice
> SystemPepperFlash doesn't exist on Linux, and I'm slightly worried about
> short-circuiting the "fake Flash plugin" if  GetComponentUpdatedPepperFlash
> returns false.

I think you're right. The override is less obvious, but also much less prone to
break things.

[commit-bot: I haz the power, 2016-12-02 01:06:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-02 02:13:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-02 02:13:34]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Greg K, 2016-12-02 19:03:42]

kerrnel@chromium.org changed reviewers:
+ thestig@chromium.org

[Greg K, 2016-12-02 19:03:42]

thestig@chromium.org: Please review changes in 

chrome/common/chrome_content_client.cc

Thanks,

Greg

[waffles, 2016-12-02 20:01:23]

still lgtm

[Greg K, 2016-12-05 18:31:26]

Description was changed from

==========
Add flags entries to test chrome OS component updates in release mode.

This adds two new flags to chrome://flags so that component updates, on
Chrome OS, can be tested in release mode. The flags enable flash
updates for Chrome OS (currently a finch experiment), and enable only
component flash in the browswer (disabling the system plugin).

BUG=670421
==========

to

==========
Add flags entries to test chrome OS component updates in release mode.

This adds two new flags to chrome://flags so that component updates, on
Chrome OS, can be tested in release mode. The flags enable flash
updates for Chrome OS (currently a finch experiment), and enable only
component flash in the browswer (disabling the system plugin).

BUG=670421
==========

[Greg K, 2016-12-05 18:31:26]

kerrnel@chromium.org changed reviewers:
+ thakis@chromium.org
- thestig@chromium.org

[Greg K, 2016-12-05 18:31:46]

It looks like thestig@ is OOO, so Nico can you take a look?

Thanks,

Greg

[Nico, 2016-12-05 18:42:30]

thakis@chromium.org changed reviewers:
+ asvitkine@chromium.org

[Nico, 2016-12-05 18:42:30]

lgtm, but +asvitkine since I keep forgetting how finch stuff should be done on
about:flags. I think this is right though.

[Alexei Svitkine (slow), 2016-12-05 18:44:35]

lgtm

[Greg K, 2016-12-05 18:45:06]

The CQ bit was checked by kerrnel@chromium.org

[commit-bot: I haz the power, 2016-12-05 18:45:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-05 18:48:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-05 18:48:33]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Greg K, 2016-12-05 23:23:29]

On 2016/12/05 18:48:33, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
>   mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

I rebased the CL.

[Greg K, 2016-12-05 23:23:36]

The CQ bit was checked by kerrnel@chromium.org

[Greg K, 2016-12-05 23:23:37]

The patchset sent to the CQ was uploaded after l-g-t-m from
waffles@chromium.org, thakis@chromium.org, asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2544133002/#ps40001
(title: "Add flags entries to test chrome OS component updates in release
mode.")

[commit-bot: I haz the power, 2016-12-05 23:24:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 00:18:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 00:18:38]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Greg K, 2016-12-06 01:27:02]

The CQ bit was checked by kerrnel@chromium.org to run a CQ dry run

[Greg K, 2016-12-06 01:27:21]

asvitkine@, can you take a look at the histograms.xml changes that I forgot to
include the first time?

Thanks,

Greg

[commit-bot: I haz the power, 2016-12-06 01:27:37]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 02:23:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-06 02:23:02]

Dry run: This issue passed the CQ dry run.

[Alexei Svitkine (slow), 2016-12-06 15:40:34]

lgtm

[Greg K, 2016-12-06 18:06:33]

The CQ bit was checked by kerrnel@chromium.org

[Greg K, 2016-12-06 18:06:33]

The patchset sent to the CQ was uploaded after l-g-t-m from
waffles@chromium.org, thakis@chromium.org
Link to the patchset: https://codereview.chromium.org/2544133002/#ps60001
(title: "Add flags entries to test chrome OS component updates in release
mode.")

[commit-bot: I haz the power, 2016-12-06 18:07:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-06 18:12:41]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481047593328550,
"parent_rev": "b14f704c9429c136f913b87a0a48a59c82aeb7a0", "commit_rev":
"90bed947584a443672208899bae69de0baf89734"}

[commit-bot: I haz the power, 2016-12-06 18:13:09]

Description was changed from

==========
Add flags entries to test chrome OS component updates in release mode.

This adds two new flags to chrome://flags so that component updates, on
Chrome OS, can be tested in release mode. The flags enable flash
updates for Chrome OS (currently a finch experiment), and enable only
component flash in the browswer (disabling the system plugin).

BUG=670421
==========

to

==========
Add flags entries to test chrome OS component updates in release mode.

This adds two new flags to chrome://flags so that component updates, on
Chrome OS, can be tested in release mode. The flags enable flash
updates for Chrome OS (currently a finch experiment), and enable only
component flash in the browswer (disabling the system plugin).

BUG=670421
==========

[commit-bot: I haz the power, 2016-12-06 18:13:10]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-06 18:15:22]

Description was changed from

==========
Add flags entries to test chrome OS component updates in release mode.

This adds two new flags to chrome://flags so that component updates, on
Chrome OS, can be tested in release mode. The flags enable flash
updates for Chrome OS (currently a finch experiment), and enable only
component flash in the browswer (disabling the system plugin).

BUG=670421
==========

to

==========
Add flags entries to test chrome OS component updates in release mode.

This adds two new flags to chrome://flags so that component updates, on
Chrome OS, can be tested in release mode. The flags enable flash
updates for Chrome OS (currently a finch experiment), and enable only
component flash in the browswer (disabling the system plugin).

BUG=670421

Committed: https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798
Cr-Commit-Position: refs/heads/master@{#436646}
==========

[commit-bot: I haz the power, 2016-12-06 18:15:24]

Patchset 4 (id:??) landed as
https://crrev.com/658a3dc11300924b70ac3097922b8ae0cd632798
Cr-Commit-Position: refs/heads/master@{#436646}