Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

Issue 2565023002: Use GURLs in Physical Web data source (Closed)
Patch Set: Register missing dependencies Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
index 68313a86c62baa1f5dda49aff8e369e6e988753b..f091962cbf07b7b374bc0cd45e9a8277e5445da4 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc
@@ -272,16 +272,16 @@ ContentSuggestion PhysicalWebPageSuggestionsProvider::ConvertPhysicalWebPage(
}
// PhysicalWebListener implementation.
-void PhysicalWebPageSuggestionsProvider::OnFound(const std::string& url) {
+void PhysicalWebPageSuggestionsProvider::OnFound(const GURL& url) {
FetchPhysicalWebPages();
}
-void PhysicalWebPageSuggestionsProvider::OnLost(const std::string& url) {
- InvalidateSuggestion(url);
+void PhysicalWebPageSuggestionsProvider::OnLost(const GURL& url) {
+ InvalidateSuggestion(url.spec());
nyquist 2016/12/13 18:01:40 Nit: This seems to be the only caller of Invalidat
cco3 2016/12/13 19:53:41 I think a page_id is supposed to be a string rathe
}
void PhysicalWebPageSuggestionsProvider::OnDistanceChanged(
- const std::string& url,
+ const GURL& url,
double distance_estimate) {
FetchPhysicalWebPages();
}

Powered by Google App Engine
This is Rietveld 408576698