Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h

Issue 2565023002: Use GURLs in Physical Web data source (Closed)
Patch Set: Register missing dependencies Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
index e0bc88859982ff0762b211a1d690b2feb0431fe6..46b8108fc8b066bf41fe1adf2774fa43089841de 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h
@@ -6,7 +6,6 @@
#define COMPONENTS_NTP_SNIPPETS_PHYSICAL_WEB_PAGES_PHYSICAL_WEB_PAGE_SUGGESTIONS_PROVIDER_H_
#include <set>
-#include <string>
#include <vector>
#include "base/callback_forward.h"
@@ -21,6 +20,7 @@
class PrefRegistrySimple;
class PrefService;
+class GURL;
namespace ntp_snippets {
@@ -80,10 +80,9 @@ class PhysicalWebPageSuggestionsProvider
const base::DictionaryValue& page) const;
// PhysicalWebListener implementation.
- void OnFound(const std::string& url) override;
- void OnLost(const std::string& url) override;
- void OnDistanceChanged(const std::string& url,
- double distance_estimate) override;
+ void OnFound(const GURL& url) override;
+ void OnLost(const GURL& url) override;
+ void OnDistanceChanged(const GURL& url, double distance_estimate) override;
// Fires the |OnSuggestionInvalidated| event for the suggestion corresponding
// to the given |page_id| and deletes it from the dismissed IDs list, if

Powered by Google App Engine
This is Rietveld 408576698