Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc

Issue 2565023002: Use GURLs in Physical Web data source (Closed)
Patch Set: Register missing dependencies Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
index 3f720f40777457521ce9a7ffba2c25f2e667e6a1..61a4fb413c403fd0a3f168ae42a2874e1af0a5e5 100644
--- a/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider_unittest.cc
@@ -23,6 +23,7 @@
#include "components/prefs/testing_pref_service.h"
#include "testing/gmock/include/gmock/gmock.h"
#include "testing/gtest/include/gtest/gtest.h"
+#include "url/gurl.h"
using base::DictionaryValue;
using base::ListValue;
@@ -115,14 +116,14 @@ class PhysicalWebPageSuggestionsProviderTest : public testing::Test {
}
void FireUrlFound(const std::string& url) {
- physical_web_data_source_.NotifyOnFound(url);
+ physical_web_data_source_.NotifyOnFound(GURL(url));
}
void FireUrlLost(const std::string& url) {
- physical_web_data_source_.NotifyOnLost(url);
+ physical_web_data_source_.NotifyOnLost(GURL(url));
}
- void FireUrlDistanceChanged(const std::string& url, double new_distance) {
+ void FireUrlDistanceChanged(const GURL& url, double new_distance) {
physical_web_data_source_.NotifyOnDistanceChanged(url, new_distance);
}

Powered by Google App Engine
This is Rietveld 408576698