Use GURLs in Physical Web data source

components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/ntp_snippets/physical_web_pages/physical_web_page_suggestions_provider.h"
 
 #include <algorithm>
 #include <memory>
 #include <set>
 #include <string>
@@ skipping 254 matching lines @@
   // (see crbug.com/667722).
   suggestion.set_publish_date(
       base::Time::FromTimeT(static_cast<time_t>(scan_timestamp)));
   suggestion.set_publisher_name(base::UTF8ToUTF16(resolved_url.host()));
   DCHECK(base::IsStringUTF8(description));
   suggestion.set_snippet_text(base::UTF8ToUTF16(description));
   return suggestion;
 }
 
 // PhysicalWebListener implementation.
-void PhysicalWebPageSuggestionsProvider::OnFound(const std::string& url) {
+void PhysicalWebPageSuggestionsProvider::OnFound(const GURL& url) {
   FetchPhysicalWebPages();
 }
 
-void PhysicalWebPageSuggestionsProvider::OnLost(const std::string& url) {
-  InvalidateSuggestion(url);
+void PhysicalWebPageSuggestionsProvider::OnLost(const GURL& url) {
+  InvalidateSuggestion(url.spec());

[nyquist, 2016/12/13 18:01:40]

Nit: This seems to be the only caller of InvalidateSuggestion. Any reason why it
doesn't take a const GURL& and does the spec internally instead?

[cco3, 2016/12/13 19:53:41]

I think a page_id is supposed to be a string rather than a URL, so it would make
sense that we pass a string.  Anyway, vitaliii can change this later if he wants
to.

 }
 
 void PhysicalWebPageSuggestionsProvider::OnDistanceChanged(
-    const std::string& url,
+    const GURL& url,
     double distance_estimate) {
   FetchPhysicalWebPages();
 }
 
 void PhysicalWebPageSuggestionsProvider::InvalidateSuggestion(
     const std::string& page_id) {
   observer()->OnSuggestionInvalidated(
       this, ContentSuggestion::ID(provided_category_, page_id));
 
   // Remove |page_id| from dismissed suggestions, if present.
@@ skipping 12 matching lines @@
 }
 
 void PhysicalWebPageSuggestionsProvider::StoreDismissedIDsToPrefs(
     const std::set<std::string>& dismissed_ids) {
   prefs::StoreDismissedIDsToPrefs(pref_service_,
                                   prefs::kDismissedPhysicalWebPageSuggestions,
                                   dismissed_ids);
 }
 
 }  // namespace ntp_snippets