Skipping renaming of begin/end/etc. should be unconditional.

Skipping renaming of begin/end/etc. should be unconditional.

Before this CL, we tried to keep renaming |begin| -> |Begin| (and
similarily for |end|, |rbegin|, |rend|) if the return type contained
"iterator" in the typename.  Unfortunately this meant that some
undesired renamed were still happening (see the bug for more details).

After this CL we will unconditionally avoid renaming |begin| (and |end|,
|rbegin|, |rend|).  We can do this rename where needed manually, after
the "big rename" is done and sticks.

BUG=672353
Committed: https://crrev.com/d5e9f965676309e39c752db5e90e286b0e892260
Cr-Commit-Position: refs/heads/master@{#437401}

[Łukasz Anforowicz, 2016-12-08 22:18:15]

lukasza@chromium.org changed reviewers:
+ dcheng@chromium.org

[Łukasz Anforowicz, 2016-12-08 22:18:16]

Daniel, could you please take a look?

[dcheng, 2016-12-08 22:27:40]

lgtm

[Łukasz Anforowicz, 2016-12-08 22:38:35]

The CQ bit was checked by lukasza@chromium.org

[commit-bot: I haz the power, 2016-12-08 22:39:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 01:16:00]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481236715201170, "parent_rev":
"06233593a6fbc228c768f58f0cdd58391dc6f8d6", "commit_rev":
"a1cb0f12c93540ee4fb8cb525b1a5cca2ac4494c"}

[commit-bot: I haz the power, 2016-12-09 01:16:50]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-09 01:20:26]

Description was changed from

==========
Skipping renaming of begin/end/etc. should be unconditional.

Before this CL, we tried to keep renaming |begin| -> |Begin| (and
similarily for |end|, |rbegin|, |rend|) if the return type contained
"iterator" in the typename.  Unfortunately this meant that some
undesired renamed were still happening (see the bug for more details).

After this CL we will unconditionally avoid renaming |begin| (and |end|,
|rbegin|, |rend|).  We can do this rename where needed manually, after
the "big rename" is done and sticks.

BUG=672353
==========

to

==========
Skipping renaming of begin/end/etc. should be unconditional.

Before this CL, we tried to keep renaming |begin| -> |Begin| (and
similarily for |end|, |rbegin|, |rend|) if the return type contained
"iterator" in the typename.  Unfortunately this meant that some
undesired renamed were still happening (see the bug for more details).

After this CL we will unconditionally avoid renaming |begin| (and |end|,
|rbegin|, |rend|).  We can do this rename where needed manually, after
the "big rename" is done and sticks.

BUG=672353

Committed: https://crrev.com/d5e9f965676309e39c752db5e90e286b0e892260
Cr-Commit-Position: refs/heads/master@{#437401}
==========

[commit-bot: I haz the power, 2016-12-09 01:20:27]

Patchset 1 (id:??) landed as
https://crrev.com/d5e9f965676309e39c752db5e90e286b0e892260
Cr-Commit-Position: refs/heads/master@{#437401}