Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/methods-expected.cc

Issue 2564663002: Skipping renaming of begin/end/etc. should be unconditional. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gen/thing.h" 5 #include "gen/thing.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 8
9 class InterfaceOutsideOfBlink { 9 class InterfaceOutsideOfBlink {
10 public: 10 public:
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 }; 63 };
64 64
65 class Other { 65 class Other {
66 // Static begin/end/trace don't count, and should be renamed. 66 // Static begin/end/trace don't count, and should be renamed.
67 static MyIterator Begin() {} 67 static MyIterator Begin() {}
68 static my_iterator End() {} 68 static my_iterator End() {}
69 static void Trace() {} 69 static void Trace() {}
70 static void Lock() {} 70 static void Lock() {}
71 }; 71 };
72 72
73 class NonIterators {
74 // begin()/end() and friends are renamed if they don't return an iterator.
75 void Begin() {}
76 int End() { return 0; }
77 void Rbegin() {}
78 int Rend() { return 0; }
79 };
80
81 // Test that the actual method definition is also updated. 73 // Test that the actual method definition is also updated.
82 void Task::DoTheWork() { 74 void Task::DoTheWork() {
83 ReallyDoTheWork(); 75 ReallyDoTheWork();
84 } 76 }
85 77
86 template <typename T> 78 template <typename T>
87 class Testable { 79 class Testable {
88 public: 80 public:
89 typedef T Testable::*UnspecifiedBoolType; 81 typedef T Testable::*UnspecifiedBoolType;
90 // This method has a reference to a member in a "member context" and a 82 // This method has a reference to a member in a "member context" and a
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
229 static void Method(); 221 static void Method();
230 }; 222 };
231 223
232 } // namespace internal 224 } // namespace internal
233 225
234 } // namespace blink 226 } // namespace blink
235 227
236 // https://crbug.com/640688 - need to rewrite method name below. 228 // https://crbug.com/640688 - need to rewrite method name below.
237 void blink::ClassDeclaredInsideBlink::MethodDefinedOutsideBlink() {} 229 void blink::ClassDeclaredInsideBlink::MethodDefinedOutsideBlink() {}
238 void blink::internal::InternalClass::Method() {} 230 void blink::internal::InternalClass::Method() {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698