Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(226)

Side by Side Diff: tools/clang/rewrite_to_chrome_style/tests/methods-original.cc

Issue 2564663002: Skipping renaming of begin/end/etc. should be unconditional. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "gen/thing.h" 5 #include "gen/thing.h"
6 6
7 namespace v8 { 7 namespace v8 {
8 8
9 class InterfaceOutsideOfBlink { 9 class InterfaceOutsideOfBlink {
10 public: 10 public:
(...skipping 56 matching lines...) Expand 10 before | Expand all | Expand 10 after
67 }; 67 };
68 68
69 class Other { 69 class Other {
70 // Static begin/end/trace don't count, and should be renamed. 70 // Static begin/end/trace don't count, and should be renamed.
71 static MyIterator begin() {} 71 static MyIterator begin() {}
72 static my_iterator end() {} 72 static my_iterator end() {}
73 static void trace() {} 73 static void trace() {}
74 static void lock() {} 74 static void lock() {}
75 }; 75 };
76 76
77 class NonIterators {
78 // begin()/end() and friends are renamed if they don't return an iterator.
79 void begin() {}
80 int end() { return 0; }
81 void rbegin() {}
82 int rend() { return 0; }
83 };
84
85 // Test that the actual method definition is also updated. 77 // Test that the actual method definition is also updated.
86 void Task::doTheWork() { 78 void Task::doTheWork() {
87 reallyDoTheWork(); 79 reallyDoTheWork();
88 } 80 }
89 81
90 template <typename T> 82 template <typename T>
91 class Testable { 83 class Testable {
92 public: 84 public:
93 typedef T Testable::*UnspecifiedBoolType; 85 typedef T Testable::*UnspecifiedBoolType;
94 // This method has a reference to a member in a "member context" and a 86 // This method has a reference to a member in a "member context" and a
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
233 static void method(); 225 static void method();
234 }; 226 };
235 227
236 } // namespace internal 228 } // namespace internal
237 229
238 } // namespace blink 230 } // namespace blink
239 231
240 // https://crbug.com/640688 - need to rewrite method name below. 232 // https://crbug.com/640688 - need to rewrite method name below.
241 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {} 233 void blink::ClassDeclaredInsideBlink::methodDefinedOutsideBlink() {}
242 void blink::internal::InternalClass::method() {} 234 void blink::internal::InternalClass::method() {}
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698