Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issue 2563733002: hasUnqualifiedDesugaredType now comes with clang - stop defining it outselves. (Closed)

Created:
4 years ago by Łukasz Anforowicz
Modified:
4 years ago
Reviewers:
dcheng
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

hasUnqualifiedDesugaredType now comes with clang - stop defining it outselves. BUG=670434 Committed: https://crrev.com/864789b24b99adb37737475ae5315326bc78fa80 Cr-Commit-Position: refs/heads/master@{#437321}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp View 1 chunk +0 lines, -10 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 15 (8 generated)
Łukasz Anforowicz
Daniel, can you PTAL?
4 years ago (2016-12-08 18:28:10 UTC) #4
dcheng
This is with the pinned revision or HEAD revision?
4 years ago (2016-12-08 19:41:26 UTC) #7
Łukasz Anforowicz
On 2016/12/08 19:41:26, dcheng wrote: > This is with the pinned revision or HEAD revision? ...
4 years ago (2016-12-08 19:48:34 UTC) #8
dcheng
lgtm
4 years ago (2016-12-08 20:05:15 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563733002/1
4 years ago (2016-12-08 20:06:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-08 20:35:05 UTC) #13
commit-bot: I haz the power
4 years ago (2016-12-08 20:36:42 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/864789b24b99adb37737475ae5315326bc78fa80
Cr-Commit-Position: refs/heads/master@{#437321}

Powered by Google App Engine
This is Rietveld 408576698