Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2564613003: Timeline: fix a bunch of references to out-of-file privates (Closed)

Created:
4 years ago by caseq
Modified:
4 years ago
Reviewers:
alph, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Timeline: fix a bunch of references to out-of-file privates Committed: https://crrev.com/99e95bf3167f1e957f8baaff3e5e35598ff72493 Cr-Commit-Position: refs/heads/master@{#437607}

Patch Set 1 #

Total comments: 2

Messages

Total messages: 11 (6 generated)
caseq
4 years ago (2016-12-09 03:59:55 UTC) #3
alph
lgtm https://codereview.chromium.org/2564613003/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js File third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js (right): https://codereview.chromium.org/2564613003/diff/20001/third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js#newcode371 third_party/WebKit/Source/devtools/front_end/timeline/TimelineEventOverview.js:371: // This is due to usage of new ...
4 years ago (2016-12-09 05:53:37 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2564613003/20001
4 years ago (2016-12-09 17:16:28 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-09 19:29:38 UTC) #9
commit-bot: I haz the power
4 years ago (2016-12-12 14:36:53 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/99e95bf3167f1e957f8baaff3e5e35598ff72493
Cr-Commit-Position: refs/heads/master@{#437607}

Powered by Google App Engine
This is Rietveld 408576698