third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js - Issue 2564613003: Timeline: fix a bunch of references to out-of-file privates

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

Issue 2564613003: Timeline: fix a bunch of references to out-of-file privates (Closed)

Patch Set: Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChart.js ('K') | « third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js ('k') | third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

index 6759fb92551ef77e615d861aff471e2b1dd31358..a6c73d37145f6d48f3aec29efa5b0d89dcf1f2b0 100644

--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineNetworkFlameChart.js

@@ -10,7 +10,10 @@ Timeline.TimelineFlameChartNetworkDataProvider = class extends Timeline.Timeline

* @param {!TimelineModel.TimelineModel} model

constructor(model) {

- super(model, []);

+ super();

+ this._model = model;

+ /** @type {?UI.FlameChart.TimelineData} */

+ this._timelineData = null;

var loadingCategory = Timeline.TimelineUIUtils.categories()['loading'];

this._waitingColor = loadingCategory.childColor;

this._processingColor = loadingCategory.color;

@@ -48,6 +51,7 @@ Timeline.TimelineFlameChartNetworkDataProvider = class extends Timeline.Timeline

reset() {

super.reset();

+ this._timelineData = null;

/** @type {!Array<!TimelineModel.TimelineModel.NetworkRequest>} */

this._requests = [];

}