Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Unified Diff: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js

Issue 2564613003: Timeline: fix a bunch of references to out-of-file privates (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
index 49fc5a1f393f2ed1d0b0f6a49635be0ffbc2bf01..8e10f9a6e2ce2e543a120d056c89059418ffb331 100644
--- a/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
+++ b/third_party/WebKit/Source/devtools/front_end/timeline/TimelineFlameChartView.js
@@ -7,18 +7,15 @@
* @unrestricted
*/
Timeline.TimelineFlameChartDataProviderBase = class {
- /**
- * @param {!TimelineModel.TimelineModel} model
- * @param {!Array<!TimelineModel.TimelineModel.Filter>} filters
- */
- constructor(model, filters) {
+ constructor() {
UI.FlameChartDataProvider.call(this);
this.reset();
- this._model = model;
- /** @type {?UI.FlameChart.TimelineData} */
- this._timelineData;
this._font = '11px ' + Host.fontFamily();
- this._filters = filters;
+ }
+
+ /** @return {string} */
+ font() {
+ return this._font;
}
/**
@@ -186,16 +183,6 @@ Timeline.TimelineFlameChartDataProviderBase = class {
timelineData() {
throw new Error('Not implemented');
}
-
- /**
- * @param {!SDK.TracingModel.Event} event
- * @return {boolean}
- */
- _isVisible(event) {
- return this._filters.every(function(filter) {
- return filter.accept(event);
- });
- }
};
/**

Powered by Google App Engine
This is Rietveld 408576698