ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with CallbackPromiseAdapter

ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with CallbackPromiseAdapter

This is a cleanup CL and does not change behavior.

BUG=n/a

Committed: https://crrev.com/abcca45f76f592a6e1f816e0a04138723ada054d
Cr-Commit-Position: refs/heads/master@{#438061}

[nhiroki, 2016-12-12 09:55:21]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 09:55:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-12-12 09:56:32]

Patchset #1 (id:1) has been deleted

[nhiroki, 2016-12-12 10:00:00]

The CQ bit was checked by nhiroki@chromium.org to run a CQ dry run

[nhiroki, 2016-12-12 10:00:07]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2016-12-12 10:00:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nhiroki, 2016-12-12 10:12:00]

nhiroki@chromium.org changed reviewers:
+ falken@chromium.org, shimazu@chromium.org

[nhiroki, 2016-12-12 10:12:01]

PTAL, thanks!

[shimazu, 2016-12-12 11:04:53]

lgtm with nit

https://codereview.chromium.org/2564363002/diff/40001/content/child/service_w...
File content/child/service_worker/service_worker_dispatcher.cc (right):

https://codereview.chromium.org/2564363002/diff/40001/content/child/service_w...
content/child/service_worker/service_worker_dispatcher.cc:529: new
WebServiceWorkerRegistrationHandles(infos.size()));
nit: base::MakeUnique would be better than the bare new.

std::unique_ptr<WebServiceWorkerRegistrationHandles> registrations = 
    base::MakeUnique<WebServiceWorkerRegistrationHandles>(infos.size());

[commit-bot: I haz the power, 2016-12-12 11:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 11:12:01]

Dry run: This issue passed the CQ dry run.

[falken, 2016-12-13 02:24:25]

lgtm

[nhiroki, 2016-12-13 03:16:27]

Thank you!

https://codereview.chromium.org/2564363002/diff/40001/content/child/service_w...
File content/child/service_worker/service_worker_dispatcher.cc (right):

https://codereview.chromium.org/2564363002/diff/40001/content/child/service_w...
content/child/service_worker/service_worker_dispatcher.cc:529: new
WebServiceWorkerRegistrationHandles(infos.size()));
On 2016/12/12 11:04:53, shimazu wrote:
> nit: base::MakeUnique would be better than the bare new.
> 
> std::unique_ptr<WebServiceWorkerRegistrationHandles> registrations = 
>     base::MakeUnique<WebServiceWorkerRegistrationHandles>(infos.size());

Done.

[nhiroki, 2016-12-13 03:16:31]

The CQ bit was checked by nhiroki@chromium.org

[nhiroki, 2016-12-13 03:16:32]

The patchset sent to the CQ was uploaded after l-g-t-m from falken@chromium.org,
shimazu@chromium.org
Link to the patchset: https://codereview.chromium.org/2564363002/#ps60001
(title: "base::MakeUnique")

[commit-bot: I haz the power, 2016-12-13 03:16:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-13 05:15:56]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481598991519590,
"parent_rev": "c574da717f406a650f36973fa4c20bf3774a65d6", "commit_rev":
"ab03e07e7a9c03f6cbf5ea8fa7ab5684d548940e"}

[commit-bot: I haz the power, 2016-12-13 05:17:20]

Description was changed from

==========
ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with
CallbackPromiseAdapter

This is a cleanup CL and does not change behavior.

BUG=n/a
==========

to

==========
ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with
CallbackPromiseAdapter

This is a cleanup CL and does not change behavior.

BUG=n/a

Review-Url: https://codereview.chromium.org/2564363002
==========

[commit-bot: I haz the power, 2016-12-13 05:17:21]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-12-13 05:20:38]

Description was changed from

==========
ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with
CallbackPromiseAdapter

This is a cleanup CL and does not change behavior.

BUG=n/a

Review-Url: https://codereview.chromium.org/2564363002
==========

to

==========
ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with
CallbackPromiseAdapter

This is a cleanup CL and does not change behavior.

BUG=n/a

Committed: https://crrev.com/abcca45f76f592a6e1f816e0a04138723ada054d
Cr-Commit-Position: refs/heads/master@{#438061}
==========

[commit-bot: I haz the power, 2016-12-13 05:20:40]

Patchset 2 (id:??) landed as
https://crrev.com/abcca45f76f592a6e1f816e0a04138723ada054d
Cr-Commit-Position: refs/heads/master@{#438061}