content/child/service_worker/web_service_worker_registration_impl.h - Issue 2564363002: ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with CallbackPromiseAdapter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.h

Issue 2564363002: ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with CallbackPromiseAdapter (Closed)

Patch Set: base::MakeUnique Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/service_worker_dispatcher.cc ('k') | content/child/service_worker/web_service_worker_registration_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.h

diff --git a/content/child/service_worker/web_service_worker_registration_impl.h b/content/child/service_worker/web_service_worker_registration_impl.h

index 46144444da79d7e0309ff9e7ab6a488b10ec8d4c..9dece685879c4147f54183b458362a2b5e936933 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.h

+++ b/content/child/service_worker/web_service_worker_registration_impl.h

@@ -78,13 +78,6 @@ class CONTENT_EXPORT WebServiceWorkerRegistrationImpl

static std::unique_ptr<WebServiceWorkerRegistrationHandle> CreateHandle(

const scoped_refptr<WebServiceWorkerRegistrationImpl>& registration);

- // Same with CreateHandle(), but returns a raw pointer to the handle w/ its

- // ownership instead. The caller must manage the ownership. This function must

- // be used only for passing the handle to Blink API that does not support

- // blink::WebPassOwnPtr.

- static WebServiceWorkerRegistrationHandle* CreateLeakyHandle(

- const scoped_refptr<WebServiceWorkerRegistrationImpl>& registration);

private:

friend class base::RefCounted<WebServiceWorkerRegistrationImpl>;

~WebServiceWorkerRegistrationImpl() override;