content/child/service_worker/web_service_worker_registration_impl.cc - Issue 2564363002: ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with CallbackPromiseAdapter

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/web_service_worker_registration_impl.cc

Issue 2564363002: ServiceWorker: Replace RegistrationCallback and GetRegistrationsCallback with CallbackPromiseAdapter (Closed)

Patch Set: base::MakeUnique Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/child/service_worker/web_service_worker_registration_impl.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/child/service_worker/web_service_worker_registration_impl.cc

diff --git a/content/child/service_worker/web_service_worker_registration_impl.cc b/content/child/service_worker/web_service_worker_registration_impl.cc

index 48d440e40c3eaa4614c84b9ed1fff8fc3b700208..de0acf7b035d155c5c01d7e96c9c565576c40cfb 100644

--- a/content/child/service_worker/web_service_worker_registration_impl.cc

+++ b/content/child/service_worker/web_service_worker_registration_impl.cc

@@ -200,14 +200,6 @@ WebServiceWorkerRegistrationImpl::CreateHandle(

return base::MakeUnique<HandleImpl>(registration);

}

-blink::WebServiceWorkerRegistration::Handle*

-WebServiceWorkerRegistrationImpl::CreateLeakyHandle(

- const scoped_refptr<WebServiceWorkerRegistrationImpl>& registration) {

- if (!registration)

- return nullptr;

- return new HandleImpl(registration);

WebServiceWorkerRegistrationImpl::~WebServiceWorkerRegistrationImpl() {

ServiceWorkerDispatcher* dispatcher =

ServiceWorkerDispatcher::GetThreadSpecificInstance();