Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2563883006: [Sync] Separate purge types step from sync manager configuration. (Closed)

Created:
4 years ago by pavely
Modified:
4 years ago
Reviewers:
maxbogue
CC:
chromium-reviews, sync-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Separate purge types step from sync manager configuration. The end goal is to trigger purge from DataTypeManagerImpl at the very beginning of configuration based on information available in DataTypeManager and DataTypeControllers. In this change I moved PurgeDisabledTypes call from SyncManagerImpl::ConfigureSyncer and called it separately from SyncBackendHost{Impl/Core}. R=maxbogue@chromium.org BUG=647505 Committed: https://crrev.com/2fd351656a3ff6bd5a7ab51b0ce32cbd33e31e02 Cr-Commit-Position: refs/heads/master@{#437715}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+139 lines, -194 lines) Patch
M components/browser_sync/abstract_profile_sync_service_test.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.h View 2 chunks +4 lines, -13 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_core.cc View 3 chunks +15 lines, -16 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.h View 1 chunk +0 lines, -4 lines 0 comments Download
M components/sync/driver/glue/sync_backend_host_impl.cc View 2 chunks +6 lines, -13 lines 0 comments Download
M components/sync/engine/fake_sync_manager.h View 1 chunk +4 lines, -4 lines 0 comments Download
M components/sync/engine/fake_sync_manager.cc View 5 chunks +16 lines, -16 lines 0 comments Download
M components/sync/engine/sync_manager.h View 2 chunks +9 lines, -9 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl.h View 2 chunks +4 lines, -12 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl.cc View 4 chunks +13 lines, -29 lines 0 comments Download
M components/sync/engine_impl/sync_manager_impl_unittest.cc View 3 chunks +11 lines, -7 lines 0 comments Download
M components/sync/syncable/directory.h View 1 chunk +3 lines, -5 lines 0 comments Download
M components/sync/syncable/directory.cc View 1 chunk +54 lines, -58 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
pavely
4 years ago (2016-12-09 20:18:52 UTC) #3
maxbogue
lgtm
4 years ago (2016-12-09 23:35:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563883006/1
4 years ago (2016-12-09 23:42:01 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-10 01:52:57 UTC) #11
commit-bot: I haz the power
4 years ago (2016-12-12 14:59:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fd351656a3ff6bd5a7ab51b0ce32cbd33e31e02
Cr-Commit-Position: refs/heads/master@{#437715}

Powered by Google App Engine
This is Rietveld 408576698