Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Unified Diff: components/sync/driver/glue/sync_backend_host_core.cc

Issue 2563883006: [Sync] Separate purge types step from sync manager configuration. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync/driver/glue/sync_backend_host_core.cc
diff --git a/components/sync/driver/glue/sync_backend_host_core.cc b/components/sync/driver/glue/sync_backend_host_core.cc
index 3fcbdbcb5e106427c8a5f0939383746e60f545b2..9fe765d7593f6124b6fe1c9a7438470da8cfed22 100644
--- a/components/sync/driver/glue/sync_backend_host_core.cc
+++ b/components/sync/driver/glue/sync_backend_host_core.cc
@@ -102,13 +102,6 @@ DoInitializeOptions::DoInitializeOptions(
DoInitializeOptions::~DoInitializeOptions() {}
-DoConfigureSyncerTypes::DoConfigureSyncerTypes() {}
-
-DoConfigureSyncerTypes::DoConfigureSyncerTypes(
- const DoConfigureSyncerTypes& other) = default;
-
-DoConfigureSyncerTypes::~DoConfigureSyncerTypes() {}
-
SyncBackendHostCore::SyncBackendHostCore(
const std::string& name,
const base::FilePath& sync_data_folder_path,
@@ -202,9 +195,10 @@ void SyncBackendHostCore::OnInitializationComplete(
ModelTypeSet types_to_purge =
Difference(ModelTypeSet::All(), GetRoutingInfoTypes(routing_info));
+ sync_manager_->PurgeDisabledTypes(types_to_purge, ModelTypeSet(),
+ ModelTypeSet());
sync_manager_->ConfigureSyncer(
- reason, new_control_types, types_to_purge, ModelTypeSet(), ModelTypeSet(),
- routing_info,
+ reason, new_control_types, routing_info,
base::Bind(&SyncBackendHostCore::DoInitialProcessControlTypes,
weak_ptr_factory_.GetWeakPtr()),
base::Closure());
@@ -554,24 +548,29 @@ void SyncBackendHostCore::DoDestroySyncManager(ShutdownReason reason) {
}
}
+void SyncBackendHostCore::DoPurgeDisabledTypes(const ModelTypeSet& to_purge,
+ const ModelTypeSet& to_journal,
+ const ModelTypeSet& to_unapply) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ sync_manager_->PurgeDisabledTypes(to_purge, to_journal, to_unapply);
+}
+
void SyncBackendHostCore::DoConfigureSyncer(
ConfigureReason reason,
- const DoConfigureSyncerTypes& config_types,
+ const ModelTypeSet& to_download,
const ModelSafeRoutingInfo routing_info,
const base::Callback<void(ModelTypeSet, ModelTypeSet)>& ready_task,
const base::Closure& retry_callback) {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK(!ready_task.is_null());
DCHECK(!retry_callback.is_null());
- base::Closure chained_ready_task(base::Bind(
- &SyncBackendHostCore::DoFinishConfigureDataTypes,
- weak_ptr_factory_.GetWeakPtr(), config_types.to_download, ready_task));
+ base::Closure chained_ready_task(
+ base::Bind(&SyncBackendHostCore::DoFinishConfigureDataTypes,
+ weak_ptr_factory_.GetWeakPtr(), to_download, ready_task));
base::Closure chained_retry_task(
base::Bind(&SyncBackendHostCore::DoRetryConfiguration,
weak_ptr_factory_.GetWeakPtr(), retry_callback));
- sync_manager_->ConfigureSyncer(reason, config_types.to_download,
- config_types.to_purge, config_types.to_journal,
- config_types.to_unapply, routing_info,
+ sync_manager_->ConfigureSyncer(reason, to_download, routing_info,
chained_ready_task, chained_retry_task);
}
« no previous file with comments | « components/sync/driver/glue/sync_backend_host_core.h ('k') | components/sync/driver/glue/sync_backend_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698