Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: components/sync/engine_impl/sync_manager_impl.h

Issue 2563883006: [Sync] Separate purge types step from sync manager configuration. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/engine/sync_manager.h ('k') | components/sync/engine_impl/sync_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/engine_impl/sync_manager_impl.h
diff --git a/components/sync/engine_impl/sync_manager_impl.h b/components/sync/engine_impl/sync_manager_impl.h
index d448c4c15370a5709b757b0eaf2e292057e5a158..4b396e9c20d5955703ad25c9eff01fc02f822f31 100644
--- a/components/sync/engine_impl/sync_manager_impl.h
+++ b/components/sync/engine_impl/sync_manager_impl.h
@@ -67,15 +67,15 @@ class SyncManagerImpl
ModelTypeSet InitialSyncEndedTypes() override;
ModelTypeSet GetTypesWithEmptyProgressMarkerToken(
ModelTypeSet types) override;
- bool PurgePartiallySyncedTypes() override;
+ void PurgePartiallySyncedTypes() override;
+ void PurgeDisabledTypes(ModelTypeSet to_purge,
+ ModelTypeSet to_journal,
+ ModelTypeSet to_unapply) override;
void UpdateCredentials(const SyncCredentials& credentials) override;
void StartSyncingNormally(const ModelSafeRoutingInfo& routing_info,
base::Time last_poll_time) override;
void ConfigureSyncer(ConfigureReason reason,
ModelTypeSet to_download,
- ModelTypeSet to_purge,
- ModelTypeSet to_journal,
- ModelTypeSet to_unapply,
const ModelSafeRoutingInfo& new_routing_info,
const base::Closure& ready_task,
const base::Closure& retry_task) override;
@@ -219,14 +219,6 @@ class SyncManagerImpl
// Open the directory named with |username|.
bool OpenDirectory(const std::string& username);
- // Purge those disabled types as specified by |to_purge|. |to_journal| and
- // |to_unapply| specify subsets that require special handling. |to_journal|
- // types are saved into the delete journal, while |to_unapply| have only
- // their local data deleted, while their server data is preserved.
- bool PurgeDisabledTypes(ModelTypeSet to_purge,
- ModelTypeSet to_journal,
- ModelTypeSet to_unapply);
-
void RequestNudgeForDataTypes(const tracked_objects::Location& nudge_location,
ModelTypeSet type);
« no previous file with comments | « components/sync/engine/sync_manager.h ('k') | components/sync/engine_impl/sync_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698