Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2563483005: [ia32] Optimize index calculation for certain checked load/stores. (Closed)

Created:
4 years ago by shiyu.zhang
Modified:
4 years ago
Reviewers:
Benedikt Meurer, Jarin
CC:
Pan, tianyou.li
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Optimize index calculation for certain checked load/stores. It reduces the add operation for certain checked load/stores by pre-do the add in compiling phase. BUG= Committed: https://crrev.com/5c1babcc16e1b568d88af9eb4bc84e050e631039 Cr-Commit-Position: refs/heads/master@{#41671}

Patch Set 1 #

Patch Set 2 : Fix some DCHECK errors. #

Patch Set 3 : fix negative offset checked load/store errors #

Patch Set 4 : fix negative offset CheckedLoadInteger errors #

Unified diffs Side-by-side diffs Delta from patch set Stats (+417 lines, -80 lines) Patch
M src/compiler/ia32/code-generator-ia32.cc View 1 2 3 3 chunks +382 lines, -60 lines 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 2 chunks +35 lines, -20 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
shiyu.zhang
This patch did similar optimization for ia32 as what has been done in https://codereview.chromium.org/733893008 for ...
4 years ago (2016-12-09 07:30:22 UTC) #2
shiyu.zhang
PTAL
4 years ago (2016-12-12 01:42:07 UTC) #4
Benedikt Meurer
Thank you! LGTM.
4 years ago (2016-12-12 08:20:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563483005/20001
4 years ago (2016-12-12 08:23:04 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel_ng/builds/14009) v8_mac_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, ...
4 years ago (2016-12-12 08:41:44 UTC) #9
shiyu.zhang
Hi Benedikt, I have fixed the errors when checked load/stores with negative offset and updated ...
4 years ago (2016-12-13 11:25:59 UTC) #10
Benedikt Meurer
Still LGTM, thanks.
4 years ago (2016-12-13 12:11:05 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563483005/60001
4 years ago (2016-12-13 12:16:41 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years ago (2016-12-13 12:45:16 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-13 12:45:51 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/5c1babcc16e1b568d88af9eb4bc84e050e631039
Cr-Commit-Position: refs/heads/master@{#41671}

Powered by Google App Engine
This is Rietveld 408576698