Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 733893008: [x64] Fix optimization for certain checked load/stores. (Closed)

Created:
6 years ago by Benedikt Meurer
Modified:
6 years ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

[x64] Fix optimization for certain checked load/stores. BUG=chromium:439743 LOG=y TEST=mjsunit R=svenpanne@chromium.org Committed: https://chromium.googlesource.com/v8/v8/+/19418d76dfba7a48b3ab5760e2295a425b50590b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+479 lines, -81 lines) Patch
M src/compiler/x64/code-generator-x64.cc View 3 chunks +243 lines, -58 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 2 chunks +27 lines, -7 lines 0 comments Download
A test/mjsunit/asm/float32array-negative-offset.js View 1 chunk +42 lines, -0 lines 0 comments Download
A test/mjsunit/asm/float64array-negative-offset.js View 1 chunk +42 lines, -0 lines 0 comments Download
A test/mjsunit/asm/int16array-negative-offset.js View 1 chunk +42 lines, -0 lines 0 comments Download
A test/mjsunit/asm/int32array-negative-offset.js View 1 chunk +42 lines, -0 lines 0 comments Download
A test/mjsunit/asm/int8array-negative-offset.js View 1 chunk +42 lines, -0 lines 0 comments Download
A + test/mjsunit/compiler/regress-439743.js View 0 chunks +-1 lines, --1 lines 0 comments Download
D test/mjsunit/compiler/regress-lena.js View 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Benedikt Meurer
PTAL
6 years ago (2014-12-10 07:23:12 UTC) #2
Sven Panne
LGTM with a deja vu... :-D
6 years ago (2014-12-10 07:33:27 UTC) #3
Benedikt Meurer
6 years ago (2014-12-10 07:49:22 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
19418d76dfba7a48b3ab5760e2295a425b50590b (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698