Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2563023002: Add //ios/chrome/app/resources group target. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add //ios/chrome/app/resources group target. Rename old target //ios/chrome/app/resources to the more correct name //ios/chrome/app/resources:ios_resources. Add a new group target //ios/chrome/app/resources to allow multiple target to get all resources required in the application bundle and to act as "chrome" target (i.e. EarlGrey tests). BUG=672516 Committed: https://crrev.com/67c91b19007bfa9046e3805c52f2276ed42475f3 Cr-Commit-Position: refs/heads/master@{#437846}

Patch Set 1 #

Patch Set 2 : ... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M ios/chrome/BUILD.gn View 1 1 chunk +3 lines, -1 line 0 comments Download
M ios/chrome/app/resources/BUILD.gn View 2 chunks +12 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (12 generated)
sdefresne
Please take a look.
4 years ago (2016-12-09 14:24:38 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-09 14:25:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563023002/20001
4 years ago (2016-12-12 10:09:18 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2016-12-12 11:05:41 UTC) #15
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:27 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/67c91b19007bfa9046e3805c52f2276ed42475f3
Cr-Commit-Position: refs/heads/master@{#437846}

Powered by Google App Engine
This is Rietveld 408576698