Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 2562063002: Upstream target to generate localizable strings for Info.plist. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream target to generate localizable strings for Info.plist. BUG=672516 Committed: https://crrev.com/bea1e806a8e0e204ffcc9a2d3ed52ebce56c1968 Cr-Commit-Position: refs/heads/master@{#437808}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -0 lines) Patch
M ios/chrome/app/resources/BUILD.gn View 2 chunks +14 lines, -0 lines 0 comments Download
A ios/chrome/app/resources/chrome_localize_strings_config.plist View 1 chunk +68 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look.
4 years ago (2016-12-09 13:58:30 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-09 14:02:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2562063002/1
4 years ago (2016-12-11 23:22:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 01:09:24 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 15:10:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bea1e806a8e0e204ffcc9a2d3ed52ebce56c1968
Cr-Commit-Position: refs/heads/master@{#437808}

Powered by Google App Engine
This is Rietveld 408576698