Convert //ios/chrome/browser:about_flags to use buildflag_header.

Convert //ios/chrome/browser:about_flags to use buildflag_header.

The template buildflag_header allows generating a header file with
defines based on gn variables. This is better than using "defines"
on a target as only the files using the macro will depend on it
instead of all files in the target.

BUG=None

Committed: https://crrev.com/e7fd9406c80c1fd4fe954e4be56b6258f89a5805
Cr-Commit-Position: refs/heads/master@{#437858}

[sdefresne, 2016-12-12 09:20:19]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-12 09:20:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-12 09:20:55]

sdefresne@chromium.org changed reviewers:
+ olivierrobin@chromium.org

[sdefresne, 2016-12-12 09:20:56]

Please take a look.

[Olivier, 2016-12-12 09:23:37]

Description was changed from

==========
Convert //ios/chrome/browser:about_flags to use buildflag_header.

The template buildflag_header allow generating a header file with
defines based on gn variables. This is better than using "defines"
on a target as only the files using the macro will depend on it
instead of all files in the target.

BUG=None
==========

to

==========
Convert //ios/chrome/browser:about_flags to use buildflag_header.

The template buildflag_header allows generating a header file with
defines based on gn variables. This is better than using "defines"
on a target as only the files using the macro will depend on it
instead of all files in the target.

BUG=None
==========

[Olivier, 2016-12-12 09:30:00]

lgtm

[commit-bot: I haz the power, 2016-12-12 10:43:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-12 10:43:06]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2016-12-12 13:15:34]

The CQ bit was checked by sdefresne@chromium.org

[commit-bot: I haz the power, 2016-12-12 13:15:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2016-12-12 13:16:07]

stkhapugin: FYI

[commit-bot: I haz the power, 2016-12-12 13:21:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1481548534896260, "parent_rev":
"19672ceac14f481467dbf8fc48155005e2143e5c", "commit_rev":
"0a96b0e4e751ae5206b0401cd53bf980028c0646"}

[commit-bot: I haz the power, 2016-12-12 13:21:40]

Description was changed from

==========
Convert //ios/chrome/browser:about_flags to use buildflag_header.

The template buildflag_header allows generating a header file with
defines based on gn variables. This is better than using "defines"
on a target as only the files using the macro will depend on it
instead of all files in the target.

BUG=None
==========

to

==========
Convert //ios/chrome/browser:about_flags to use buildflag_header.

The template buildflag_header allows generating a header file with
defines based on gn variables. This is better than using "defines"
on a target as only the files using the macro will depend on it
instead of all files in the target.

BUG=None

Review-Url: https://codereview.chromium.org/2569663002
==========

[commit-bot: I haz the power, 2016-12-12 13:21:41]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-12-12 15:11:50]

Description was changed from

==========
Convert //ios/chrome/browser:about_flags to use buildflag_header.

The template buildflag_header allows generating a header file with
defines based on gn variables. This is better than using "defines"
on a target as only the files using the macro will depend on it
instead of all files in the target.

BUG=None

Review-Url: https://codereview.chromium.org/2569663002
==========

to

==========
Convert //ios/chrome/browser:about_flags to use buildflag_header.

The template buildflag_header allows generating a header file with
defines based on gn variables. This is better than using "defines"
on a target as only the files using the macro will depend on it
instead of all files in the target.

BUG=None

Committed: https://crrev.com/e7fd9406c80c1fd4fe954e4be56b6258f89a5805
Cr-Commit-Position: refs/heads/master@{#437858}
==========

[commit-bot: I haz the power, 2016-12-12 15:11:51]

Patchset 1 (id:??) landed as
https://crrev.com/e7fd9406c80c1fd4fe954e4be56b6258f89a5805
Cr-Commit-Position: refs/heads/master@{#437858}