Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2563013002: Remove support for overriding write_pkg_info. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for overriding write_pkg_info. All downstream target have been cleaned up, so remove the support for overridding write_pkg_info from ios_app_bundle template. BUG=672516 Committed: https://crrev.com/7d9ae11987ba8d5028c1d31152ce9465208f7efa Cr-Commit-Position: refs/heads/master@{#437842}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -6 lines) Patch
M build/config/ios/rules.gni View 1 chunk +0 lines, -6 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
sdefresne
Please take a look.
4 years ago (2016-12-09 13:20:12 UTC) #4
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-09 13:21:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2563013002/1
4 years ago (2016-12-12 09:18:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years ago (2016-12-12 10:25:52 UTC) #12
commit-bot: I haz the power
4 years ago (2016-12-12 15:11:22 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7d9ae11987ba8d5028c1d31152ce9465208f7efa
Cr-Commit-Position: refs/heads/master@{#437842}

Powered by Google App Engine
This is Rietveld 408576698