Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2923)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/config/ios/rules.gni

Issue 2563013002: Remove support for overriding write_pkg_info. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index 2f842a6abe4eaae373c6e079108986deff39b797..44788963892109e3aa09d6811fde09a5db83301a 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -420,12 +420,6 @@ template("ios_app_bundle") {
_output_name = invoker.output_name
}
- if (defined(invoker.write_pkg_info)) {
- # TODO(sdefresne): remove once all downstream target have been fixed to
- # not override this variable anymore.
- assert(invoker.write_pkg_info, "write_pkg_info cannot be overridden")
- }
-
_arch_executable_source = _target_name + "_arch_executable_sources"
_arch_executable_target = _target_name + "_arch_executable"
_lipo_executable_target = _target_name + "_executable"
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698