Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1189)

Side by Side Diff: build/config/ios/rules.gni

Issue 2563013002: Remove support for overriding write_pkg_info. (Closed)
Patch Set: Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2015 The Chromium Authors. All rights reserved. 1 # Copyright 2015 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/ios/ios_sdk.gni") 5 import("//build/config/ios/ios_sdk.gni")
6 import("//build/config/mac/base_rules.gni") 6 import("//build/config/mac/base_rules.gni")
7 import("//build/config/mac/symbols.gni") 7 import("//build/config/mac/symbols.gni")
8 import("//build/toolchain/toolchain.gni") 8 import("//build/toolchain/toolchain.gni")
9 9
10 # Invokes lipo on multiple arch-specific binaries to create a fat binary. 10 # Invokes lipo on multiple arch-specific binaries to create a fat binary.
(...skipping 402 matching lines...) Expand 10 before | Expand all | Expand 10 after
413 # default to ios_enable_code_signing if not defined. 413 # default to ios_enable_code_signing if not defined.
414 # 414 #
415 # For more information, see "gn help executable". 415 # For more information, see "gn help executable".
416 template("ios_app_bundle") { 416 template("ios_app_bundle") {
417 _output_name = target_name 417 _output_name = target_name
418 _target_name = target_name 418 _target_name = target_name
419 if (defined(invoker.output_name)) { 419 if (defined(invoker.output_name)) {
420 _output_name = invoker.output_name 420 _output_name = invoker.output_name
421 } 421 }
422 422
423 if (defined(invoker.write_pkg_info)) {
424 # TODO(sdefresne): remove once all downstream target have been fixed to
425 # not override this variable anymore.
426 assert(invoker.write_pkg_info, "write_pkg_info cannot be overridden")
427 }
428
429 _arch_executable_source = _target_name + "_arch_executable_sources" 423 _arch_executable_source = _target_name + "_arch_executable_sources"
430 _arch_executable_target = _target_name + "_arch_executable" 424 _arch_executable_target = _target_name + "_arch_executable"
431 _lipo_executable_target = _target_name + "_executable" 425 _lipo_executable_target = _target_name + "_executable"
432 426
433 source_set(_arch_executable_source) { 427 source_set(_arch_executable_source) {
434 forward_variables_from(invoker, 428 forward_variables_from(invoker,
435 "*", 429 "*",
436 [ 430 [
437 "bundle_deps", 431 "bundle_deps",
438 "bundle_deps_filter", 432 "bundle_deps_filter",
(...skipping 1021 matching lines...) Expand 10 before | Expand all | Expand 10 after
1460 "-rpath", 1454 "-rpath",
1461 "-Xlinker", 1455 "-Xlinker",
1462 "@loader_path/Frameworks", 1456 "@loader_path/Frameworks",
1463 ] 1457 ]
1464 } 1458 }
1465 } 1459 }
1466 1460
1467 set_defaults("ios_xctest_test") { 1461 set_defaults("ios_xctest_test") {
1468 configs = default_executable_configs 1462 configs = default_executable_configs
1469 } 1463 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698