exo: Replace pointer based stylus and replace with touch based stylus

exo: Replace pointer based stylus and replace with touch based stylus

This change implements the stylus_v2 protocol for touch-based
stylus events. It replaces the original stylus_v1 protocol with
a dummy. Once the client has switched to the v2 protocol, v1 will
be removed from Chrome.

BUG=665499
TEST=added unit tests. Needs to be tested in conjunction with
client-side changes.

Committed: https://crrev.com/31a496e04579111ab2894d8053fef760f16180ed
Cr-Commit-Position: refs/heads/master@{#439250}

[denniskempin, 2016-12-08 19:16:11]

denniskempin@google.com changed reviewers:
+ reveman@chromium.org, sadrul@chromium.org

[denniskempin, 2016-12-08 19:16:12]

Hey David! This is the CL actually implementing the protocol. Since stylus
events for mouse are no longer generated we can safely remove that code at this
time.

Sadrul, could you have a quick look at the additions to
	ui/events/test/event_generator.h? Just a few helper! 

Thanks a lot! :)

[reveman, 2016-12-08 23:17:14]

lgtm % nits

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch.cc
File components/exo/touch.cc (right):

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch.cc...
components/exo/touch.cc:36: : delegate_(delegate), stylus_delegate_(nullptr) {
nit: unnecessary

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch_st...
File components/exo/touch_stylus_delegate.h (right):

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch_st...
components/exo/touch_stylus_delegate.h:40: gfx::Vector2dF tilt) = 0;
nit: const gfx::Vector2dF& tilt

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch_un...
File components/exo/touch_unittest.cc (right):

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch_un...
components/exo/touch_unittest.cc:27: class TouchTest : public test::ExoTestBase
{};
why is this changing?

https://codereview.chromium.org/2562803002/diff/20001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2562803002/diff/20001/components/exo/wayland/...
components/exo/wayland/server.cc:3040: const struct zcr_stylus_v1_interface
stylus_v1_implementation = {
Alternatively you can add a _DEPRECATED suffix. That's a pattern I've used in
the past that makes it very clear that the code is going away. Either way is
fine though.

[sadrul, 2016-12-15 20:04:01]

lgtm

https://codereview.chromium.org/2562803002/diff/20001/ui/events/test/event_ge...
File ui/events/test/event_generator.h (right):

https://codereview.chromium.org/2562803002/diff/20001/ui/events/test/event_ge...
ui/events/test/event_generator.h:233: void EnterPenPointerMode();
These should now be removed, right?

[denniskempin, 2016-12-15 21:16:49]

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch.cc
File components/exo/touch.cc (right):

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch.cc...
components/exo/touch.cc:36: : delegate_(delegate), stylus_delegate_(nullptr) {
On 2016/12/08 23:17:14, reveman wrote:
> nit: unnecessary

Done.

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch_st...
File components/exo/touch_stylus_delegate.h (right):

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch_st...
components/exo/touch_stylus_delegate.h:40: gfx::Vector2dF tilt) = 0;
On 2016/12/08 23:17:14, reveman wrote:
> nit: const gfx::Vector2dF& tilt

Done.

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch_un...
File components/exo/touch_unittest.cc (right):

https://codereview.chromium.org/2562803002/diff/20001/components/exo/touch_un...
components/exo/touch_unittest.cc:27: class TouchTest : public test::ExoTestBase
{};
On 2016/12/08 23:17:14, reveman wrote:
> why is this changing?

Done.

https://codereview.chromium.org/2562803002/diff/20001/components/exo/wayland/...
File components/exo/wayland/server.cc (right):

https://codereview.chromium.org/2562803002/diff/20001/components/exo/wayland/...
components/exo/wayland/server.cc:3040: const struct zcr_stylus_v1_interface
stylus_v1_implementation = {
On 2016/12/08 23:17:14, reveman wrote:
> Alternatively you can add a _DEPRECATED suffix. That's a pattern I've used in
> the past that makes it very clear that the code is going away. Either way is
> fine though.

Done.

https://codereview.chromium.org/2562803002/diff/20001/ui/events/test/event_ge...
File ui/events/test/event_generator.h (right):

https://codereview.chromium.org/2562803002/diff/20001/ui/events/test/event_ge...
ui/events/test/event_generator.h:233: void EnterPenPointerMode();
On 2016/12/15 20:04:01, sadrul wrote:
> These should now be removed, right?

It's still used by some tests. They could be transitioned to use
SetTouchPointerType, but I do not know these tests very well.

[denniskempin, 2016-12-15 22:54:10]

The CQ bit was checked by denniskempin@google.com

[denniskempin, 2016-12-15 22:54:10]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2562803002/#ps40001
(title: "fixed nits")

[commit-bot: I haz the power, 2016-12-15 22:55:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-15 22:55:05]

This CL has an open dependency (Issue 2560493003 Patch 60001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[denniskempin, 2016-12-16 21:46:15]

The CQ bit was checked by denniskempin@google.com

[denniskempin, 2016-12-16 21:46:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2562803002/#ps60001
(title: "rebased")

[commit-bot: I haz the power, 2016-12-16 21:47:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-16 21:56:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-16 21:56:05]

Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[denniskempin, 2016-12-16 22:23:25]

The CQ bit was checked by denniskempin@google.com

[denniskempin, 2016-12-16 22:23:25]

The patchset sent to the CQ was uploaded after l-g-t-m from
reveman@chromium.org, sadrul@chromium.org
Link to the patchset: https://codereview.chromium.org/2562803002/#ps80001
(title: "updated deps in gn file")

[commit-bot: I haz the power, 2016-12-16 22:24:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-17 00:21:02]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1481927005059480,
"parent_rev": "653efd5638381b9f9aec033ec66fcc5e4be86d14", "commit_rev":
"9e1fbd19ad0f608da75b9e44c41b8df86b49fe67"}

[commit-bot: I haz the power, 2016-12-17 00:21:29]

Description was changed from

==========
exo: Replace pointer based stylus and replace with touch based stylus

This change implements the stylus_v2 protocol for touch-based
stylus events. It replaces the original stylus_v1 protocol with
a dummy. Once the client has switched to the v2 protocol, v1 will
be removed from Chrome.

BUG=665499
TEST=added unit tests. Needs to be tested in conjunction with
client-side changes.
==========

to

==========
exo: Replace pointer based stylus and replace with touch based stylus

This change implements the stylus_v2 protocol for touch-based
stylus events. It replaces the original stylus_v1 protocol with
a dummy. Once the client has switched to the v2 protocol, v1 will
be removed from Chrome.

BUG=665499
TEST=added unit tests. Needs to be tested in conjunction with
client-side changes.

Review-Url: https://codereview.chromium.org/2562803002
==========

[commit-bot: I haz the power, 2016-12-17 00:21:30]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-12-17 00:25:45]

Description was changed from

==========
exo: Replace pointer based stylus and replace with touch based stylus

This change implements the stylus_v2 protocol for touch-based
stylus events. It replaces the original stylus_v1 protocol with
a dummy. Once the client has switched to the v2 protocol, v1 will
be removed from Chrome.

BUG=665499
TEST=added unit tests. Needs to be tested in conjunction with
client-side changes.

Review-Url: https://codereview.chromium.org/2562803002
==========

to

==========
exo: Replace pointer based stylus and replace with touch based stylus

This change implements the stylus_v2 protocol for touch-based
stylus events. It replaces the original stylus_v1 protocol with
a dummy. Once the client has switched to the v2 protocol, v1 will
be removed from Chrome.

BUG=665499
TEST=added unit tests. Needs to be tested in conjunction with
client-side changes.

Committed: https://crrev.com/31a496e04579111ab2894d8053fef760f16180ed
Cr-Commit-Position: refs/heads/master@{#439250}
==========

[commit-bot: I haz the power, 2016-12-17 00:25:46]

Patchset 5 (id:??) landed as
https://crrev.com/31a496e04579111ab2894d8053fef760f16180ed
Cr-Commit-Position: refs/heads/master@{#439250}