Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2560493003: wayland-protocols: Add zcr_stylus_v2 protocol for touch based stylus (Closed)

Created:
4 years ago by denniskempin
Modified:
4 years ago
Reviewers:
reveman
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

wayland-protocols: Add zcr_stylus_v2 protocol for touch based stylus The v2 version of the protocol will extend wl_touch instead of wl_pointer to provide the same functionality. Once the clients of this protocol have been updated to use v2, we can remove the v1 protocol from this file. BUG=665499 TEST=None Committed: https://crrev.com/405afdba9798a44259deb3df45953b71bd858aa5 Cr-Commit-Position: refs/heads/master@{#439194}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : explicitly state that a tool event is only sent with a down event and doesn't change. #

Patch Set 4 : Split v1 and v2 into separate files #

Patch Set 5 : rebase #

Patch Set 6 : apply v1 update to v2. #

Messages

Total messages: 28 (17 generated)
denniskempin
PTAL.
4 years ago (2016-12-06 22:43:06 UTC) #3
reveman
lgtm
4 years ago (2016-12-07 02:48:22 UTC) #4
commit-bot: I haz the power
This CL has an open dependency (Issue 2560633002 Patch 60001). Please resolve the dependency and ...
4 years ago (2016-12-08 19:38:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560493003/60001
4 years ago (2016-12-15 22:54:23 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/357636)
4 years ago (2016-12-16 02:50:35 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560493003/60001
4 years ago (2016-12-16 17:22:10 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/327885) linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, ...
4 years ago (2016-12-16 17:47:15 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560493003/80001
4 years ago (2016-12-16 18:06:53 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2560493003/100001
4 years ago (2016-12-16 18:15:30 UTC) #23
commit-bot: I haz the power
Committed patchset #6 (id:100001)
4 years ago (2016-12-16 21:41:02 UTC) #26
commit-bot: I haz the power
4 years ago (2016-12-16 21:45:10 UTC) #28
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/405afdba9798a44259deb3df45953b71bd858aa5
Cr-Commit-Position: refs/heads/master@{#439194}

Powered by Google App Engine
This is Rietveld 408576698