Migrate WTF::Vector::append() to ::push_back() [part 2 of N]

Migrate WTF::Vector::append() to ::push_back() [part 2 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/animation/.
There are too many references to change them all at once, so this CL is
part 2 of many.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431
Committed: https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70
Cr-Commit-Position: refs/heads/master@{#437556}

[pilgrim_google, 2016-12-08 18:31:38]

The CQ bit was checked by pilgrim@chromium.org to run a CQ dry run

[pilgrim_google, 2016-12-08 18:32:05]

pilgrim@chromium.org changed reviewers:
+ esprehn@chromium.org, haraken@chromium.org, yutak@chromium.org

[commit-bot: I haz the power, 2016-12-08 18:33:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-08 20:12:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-08 20:12:16]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[haraken, 2016-12-08 23:44:32]

LGTM

However, as I mentioned in the previous CL, would you send a PSA to blink-dev@?
These renamings affect a lot of places in the code base.

[pilgrim_google, 2016-12-09 14:32:35]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-12-09 14:32:49]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 14:41:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 14:41:38]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pilgrim_google, 2016-12-09 14:57:07]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2016-12-09 14:57:07]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2562773002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-12-09 14:57:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 16:27:41]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1481295427418900,
"parent_rev": "5742ab9817b2e0775fa10905598e12bd33b61089", "commit_rev":
"86520bd0471c561a61687309b804e998caccbae2"}

[commit-bot: I haz the power, 2016-12-09 16:28:16]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 2 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/animation/.
There are too many references to change them all at once, so this CL is
part 2 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 2 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/animation/.
There are too many references to change them all at once, so this CL is
part 2 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Review-Url: https://codereview.chromium.org/2562773002
==========

[commit-bot: I haz the power, 2016-12-09 16:28:17]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-12-09 16:32:04]

Description was changed from

==========
Migrate WTF::Vector::append() to ::push_back() [part 2 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/animation/.
There are too many references to change them all at once, so this CL is
part 2 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Review-Url: https://codereview.chromium.org/2562773002
==========

to

==========
Migrate WTF::Vector::append() to ::push_back() [part 2 of N]

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL replaces append() with push_back() in Source/core/animation/.
There are too many references to change them all at once, so this CL is
part 2 of many.

There are no functional changes.

[0]
https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7...

BUG=662431

Committed: https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70
Cr-Commit-Position: refs/heads/master@{#437556}
==========

[commit-bot: I haz the power, 2016-12-09 16:32:05]

Patchset 2 (id:??) landed as
https://crrev.com/3b3f02e103d299860a03d92e415b8fb697840c70
Cr-Commit-Position: refs/heads/master@{#437556}