third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp - Issue 2562773002: Migrate WTF::Vector::append() to ::push_back() [part 2 of N]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp

Issue 2562773002: Migrate WTF::Vector::append() to ::push_back() [part 2 of N] (Closed)

Patch Set: rebase Created 4 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/animation/LengthListPropertyFunctions.cpp ('k') | third_party/WebKit/Source/core/animation/SVGLengthListInterpolationType.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp

diff --git a/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp b/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp

index 3c49d28a2170039161a2f52b447a161acdd20239..3e6c84fc5a399b8f1f122164d6ed8a5cf9b72d4a 100644

--- a/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp

+++ b/third_party/WebKit/Source/core/animation/PathInterpolationFunctions.cpp

@@ -57,10 +57,10 @@ InterpolationValue PathInterpolationFunctions::convertValue(

while (pathSource.hasMoreData()) {

const PathSegmentData segment = pathSource.parseSegment();

- interpolablePathSegs.append(

+ interpolablePathSegs.push_back(

SVGPathSegInterpolationFunctions::consumePathSeg(segment,

currentCoordinates));

- pathSegTypes.append(segment.command);

+ pathSegTypes.push_back(segment.command);

length++;

}

@@ -118,7 +118,8 @@ class UnderlyingPathSegTypesChecker

InterpolationValue PathInterpolationFunctions::maybeConvertNeutral(

const InterpolationValue& underlying,

InterpolationType::ConversionCheckers& conversionCheckers) {

- conversionCheckers.append(UnderlyingPathSegTypesChecker::create(underlying));

+ conversionCheckers.push_back(

+ UnderlyingPathSegTypesChecker::create(underlying));

std::unique_ptr<InterpolableList> result =

InterpolableList::create(PathComponentIndexCount);

result->set(PathArgsIndex, toInterpolableList(*underlying.interpolableValue)