Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2558913005: Upstream target to generate localizable strings for Info.plist. (Closed)

Created:
4 years ago by sdefresne
Modified:
4 years ago
CC:
chromium-reviews, pkl (ping after 24h if needed), sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ios_packed_resources_target to depend on packed resources. Use ios_packed_resources_target as a dependency of //ios/chrome/app target to select the correct packed resource target. BUG=653086 Committed: https://crrev.com/4032922cf601dd19088dd3c223fa141ce948ccab Cr-Commit-Position: refs/heads/master@{#437791}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M ios/chrome/BUILD.gn View 1 chunk +0 lines, -7 lines 0 comments Download
M ios/chrome/app/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 18 (13 generated)
sdefresne
Please take a look.
4 years ago (2016-12-09 13:57:18 UTC) #8
rohitrao (ping after 24h)
lgtm
4 years ago (2016-12-09 13:59:28 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2558913005/20001
4 years ago (2016-12-11 08:54:05 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years ago (2016-12-11 17:38:39 UTC) #16
commit-bot: I haz the power
4 years ago (2016-12-12 15:09:44 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4032922cf601dd19088dd3c223fa141ce948ccab
Cr-Commit-Position: refs/heads/master@{#437791}

Powered by Google App Engine
This is Rietveld 408576698